-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding RBAC for Betydb Helm components #4
base: main
Are you sure you want to change the base?
Conversation
{{- include "betydb.labels" . | nindent 4 }} | ||
rules: | ||
- apiGroups: [""] | ||
resources: ["pods", "endpoints", "Services", "configmaps"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be
resources: ["pods", "endpoints", "Services", "configmaps"] | |
resources: ["pods", "endpoints", "services", "configmaps"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed extra permissions from bety hook role
apiVersion: v1 | ||
kind: ServiceAccount | ||
metadata: | ||
name: {{ include "betydb.fullname" . }}-hooks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need a separate account for the hooks? Not sure we need all the permissions listed below for the hooks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using separate service account as permissions required for bety and bety hooks are different.
Will remove endpoint, service access from bety hook role.
rules: | ||
- apiGroups: [""] | ||
resources: ["pods", "endpoints", "Services", "configmaps"] | ||
verbs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need any permissions? I don't think right now BETY needs permissions to any of these endpoints services.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Endpoint access added for BETY role as we're accessing them in ingress config and readiness probe.
apiVersion: v1 | ||
kind: ServiceAccount | ||
metadata: | ||
name: {{ include "betydb.fullname" . }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this service account be used in the deployment file (and maybe others).
RBAC for BETYDB HELM