Make the minting table's address display match the transaction table#459
Open
IngCr3at1on wants to merge 2 commits intoPaycoinFoundation:masterfrom
IngCr3at1on:label-for-minting-tab
Open
Make the minting table's address display match the transaction table#459IngCr3at1on wants to merge 2 commits intoPaycoinFoundation:masterfrom IngCr3at1on:label-for-minting-tab
IngCr3at1on wants to merge 2 commits intoPaycoinFoundation:masterfrom
IngCr3at1on:label-for-minting-tab
Conversation
puts the addresses in parenthesis and puts the label before it. this resolves #305
Contributor
Author
|
.75 hours |
Contributor
|
As discussed in chat and to just make the comment public for discussion, I would prefer to call the already existing |
Contributor
Author
|
@MitchellCash yeah I'll fix that, I didn't notice the function in there as it's dead currently lol. |
Contributor
Author
|
@MitchellCash this has been changed per our discussion (and retested) I'll rebase it after review (before merge). (20 minutes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
puts the addresses in parenthesis and puts the label before it.
this resolves #305