Allow RPC clearorphans command to properly clear orphans in a QT wallet#428
Open
IngCr3at1on wants to merge 1 commit intoPaycoinFoundation:masterfrom
IngCr3at1on:qt-rpc-clear-orphans
Open
Allow RPC clearorphans command to properly clear orphans in a QT wallet#428IngCr3at1on wants to merge 1 commit intoPaycoinFoundation:masterfrom IngCr3at1on:qt-rpc-clear-orphans
IngCr3at1on wants to merge 1 commit intoPaycoinFoundation:masterfrom
IngCr3at1on:qt-rpc-clear-orphans
Conversation
Contributor
Author
|
This addresses #307 (1 hour) |
|
I'll give this a test tomorrow. |
Currently the behavior is to only call ClearOrphans in wallet.cpp which clears the actual orphan transactions but does not remove them from the transaction view. This makes it so the transaction view is cleared in the event that clearorphans is issued through RPC on a QT wallet.
Contributor
Author
|
Rebased over master do to merge conflicts (25 minutes) |
Contributor
Author
|
I'd like to get this tested and merged @CeForce and @MitchellCash |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the behavior is to only call ClearOrphans in wallet.cpp
which clears the actual orphan transactions but does not remove them
from the transaction view.
This makes it so the transaction view is cleared in the event that
clearorphans is issued through RPC (or the console) on a QT wallet.