Open
Conversation
Contributor
There was a problem hiding this comment.
Interesting that we remove 2 here but only add 1 below...
Main problem with these tests, they check if something is thrown but have no valid way to check what (this is an issue with a lot of the tests actually).
Contributor
There was a problem hiding this comment.
Yeah unless I'm mistaken that 1 comment is also wrong but otherwise this PR seems safe enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sizeof(const char*) == 4 or 8 (on "sane" processor architectures) :-), sizeof(const char[]) is what you want.
As written the first substring was "04" and the second was "88c2" (on 32 bits architectures)
And I have changed the +2 in +1 so that the comment is right.