Small logical error in mruset#411
Open
MitchellCash wants to merge 1 commit intoPaycoinFoundation:masterfrom
Open
Small logical error in mruset#411MitchellCash wants to merge 1 commit intoPaycoinFoundation:masterfrom
MitchellCash wants to merge 1 commit intoPaycoinFoundation:masterfrom
Conversation
….size() must be <= 5, so the exit condition must be <=, so the continuing condition must be > (and not >= as it was).
Contributor
|
For some reason that commit message makes very little sense to me lol. |
Contributor
|
Added trivial label since this doesn't directly effect the program. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As written if you make a new_size(10) the mruset will be reduced to up to 9 elements (the while will exit when !(queue.size() >= 10) so (queue.size() < 10).
This "feature" of reducing the mruset length isn't used, so the impact on the program should be zero.