Skip to content

Emails: Set up email backend structure - #30

Closed
isabellalam12 wants to merge 5 commits into
mainfrom
06-19-change_rec_to_per._run_prettier_on_json_file
Closed

Emails: Set up email backend structure#30
isabellalam12 wants to merge 5 commits into
mainfrom
06-19-change_rec_to_per._run_prettier_on_json_file

Conversation

@isabellalam12

Copy link
Copy Markdown
Member

Emails: Set up email backend structure

Update email-feature.md

Condense email-feature.md, rename variable, add JSON examples.

Change 'recipient' variables to 'rec'

Change rec to per. Run prettier on JSON file

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@isabellalam12
isabellalam12 marked this pull request as ready for review June 19, 2026 20:01
@isabellalam12
isabellalam12 requested a review from a team as a code owner June 19, 2026 20:01
@graphite-app
graphite-app Bot requested review from Arshadul-Monir and arklian June 19, 2026 20:01
Comment on lines +22 to +33
{
"recipients": [
{
"email": "cara@example.com",
"variableToValue": { "firstName": "Cara" }
},
{
"email": "dan@example.com",
"variableToValue": { "firstName": "Dan" }
}
]
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second message is missing the required variables field containing month. The body template references ${month} without a default value, which will cause this message to fail with an IllegalArgumentException during rendering.

Impact: This example file will fail when used for manual testing via Postman (as described in the documentation).

Fix: Add the variables field to the second message:

{
  "variables": { "month": "July" },
  "recipients": [
    ...
  ]
}
Suggested change
{
"recipients": [
{
"email": "cara@example.com",
"variableToValue": { "firstName": "Cara" }
},
{
"email": "dan@example.com",
"variableToValue": { "firstName": "Dan" }
}
]
}
{
"variables": { "month": "July" },
"recipients": [
{
"email": "cara@example.com",
"variableToValue": { "firstName": "Cara" }
},
{
"email": "dan@example.com",
"variableToValue": { "firstName": "Dan" }
}
]
}

Spotted by Graphite

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

@graphite-app

graphite-app Bot commented Jun 19, 2026

Copy link
Copy Markdown

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (06/19/26)

2 reviewers were added to this PR based on Henry Chen's automation.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant