Emails: Set up email backend structure - #30
Closed
isabellalam12 wants to merge 5 commits into
Closed
Conversation
Comment on lines
+22
to
+33
| { | ||
| "recipients": [ | ||
| { | ||
| "email": "cara@example.com", | ||
| "variableToValue": { "firstName": "Cara" } | ||
| }, | ||
| { | ||
| "email": "dan@example.com", | ||
| "variableToValue": { "firstName": "Dan" } | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
The second message is missing the required variables field containing month. The body template references ${month} without a default value, which will cause this message to fail with an IllegalArgumentException during rendering.
Impact: This example file will fail when used for manual testing via Postman (as described in the documentation).
Fix: Add the variables field to the second message:
{
"variables": { "month": "July" },
"recipients": [
...
]
}
Suggested change
| { | |
| "recipients": [ | |
| { | |
| "email": "cara@example.com", | |
| "variableToValue": { "firstName": "Cara" } | |
| }, | |
| { | |
| "email": "dan@example.com", | |
| "variableToValue": { "firstName": "Dan" } | |
| } | |
| ] | |
| } | |
| { | |
| "variables": { "month": "July" }, | |
| "recipients": [ | |
| { | |
| "email": "cara@example.com", | |
| "variableToValue": { "firstName": "Cara" } | |
| }, | |
| { | |
| "email": "dan@example.com", | |
| "variableToValue": { "firstName": "Dan" } | |
| } | |
| ] | |
| } | |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (06/19/26)2 reviewers were added to this PR based on Henry Chen's automation. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Emails: Set up email backend structure
Update email-feature.md
Condense email-feature.md, rename variable, add JSON examples.
Change 'recipient' variables to 'rec'
Change rec to per. Run prettier on JSON file