Skip to content

911: Added <your name> to credits - #890

Closed
Arshadul-Monir wants to merge 1 commit into
mainfrom
911
Closed

911: Added <your name> to credits#890
Arshadul-Monir wants to merge 1 commit into
mainfrom
911

Conversation

@Arshadul-Monir

@Arshadul-Monir Arshadul-Monir commented Apr 11, 2026

Copy link
Copy Markdown
Member

911

Description of changes

Added as a contributor to /api endpoint

Checklist before review

  • I have done a thorough self-review of the PR
  • Copilot has reviewed my latest changes, and all comments have been fixed and/or closed.
  • If I have made database changes, I have made sure I followed all the db repo rules listed in the wiki here. (check if no db changes)
  • All tests have passed
  • I have successfully deployed this PR to staging
  • I have done manual QA in both dev (and staging if possible) and attached screenshots below.

Screenshots

Dev

Staging

@github-actions

Copy link
Copy Markdown
Contributor

Available PR Commands

  • /ai - Triggers all AI review commands at once
  • /review - AI review of the PR changes
  • /describe - AI-powered description of the PR
  • /improve - AI-powered suggestions
  • /deploy - Deploy to staging

See: https://github.com/tahminator/codebloom/wiki/CI-Commands

@github-actions

Copy link
Copy Markdown
Contributor

Ticket Validation Failed

The following issues were found with the attached ticket:

  • Ticket does not have an assignee.

@Arshadul-Monir

Copy link
Copy Markdown
Member Author

/deploy

@github-actions

Copy link
Copy Markdown
Contributor

Title

911: Added to credits


PR Type

Enhancement


Description

  • Increased Leetcode client wait time.

  • Adjusted rate limiter from 100ms to 1000ms.


Diagram Walkthrough

flowchart LR
  A["ThrottledLeetcodeClientImpl.java"] -- "Adjust MILLISECONDS_TO_WAIT" --> B["Rate Limiter Behavior"]
Loading

File Walkthrough

Relevant files
Enhancement
ThrottledLeetcodeClientImpl.java
Adjust Leetcode API client rate limit wait                             

src/main/java/org/patinanetwork/codebloom/common/leetcode/throttled/ThrottledLeetcodeClientImpl.java

  • Updated the MILLISECONDS_TO_WAIT constant.
  • Increased the wait time for the Leetcode API client's rate limiter
    from 100L to 1000L.
+1/-1     

@github-actions

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

PR Mismatch

The code change modifies a rate-limiting constant in the ThrottledLeetcodeClientImpl, increasing the wait time between requests from 100ms to 1000ms. This is completely unrelated to the PR description, which states that a contributor was added to an API endpoint. This suggests either the wrong code was committed or the PR description is incorrect.

private static final long MILLISECONDS_TO_WAIT = 1000L;
Performance Impact

The MILLISECONDS_TO_WAIT constant has been increased tenfold from 100ms to 1000ms. This will significantly reduce the rate at which requests are made to the Leetcode API, potentially impacting features that rely on timely data fetching. Please confirm if this change is intentional to comply with new rate limits or if it's an accidental regression.

private static final long MILLISECONDS_TO_WAIT = 1000L;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant