Skip to content

861: Swap toggle button and text #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naanci merged 1 commit into from
Mar 22, 2026
Merged

861: Swap toggle button and text #866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions js/src/components/ui/dropdown/FilterDropdownItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,18 @@ export default function FilterDropdownItem({
disabled={disabled}
{...props}
leftSection={
switchMode ?
!switchMode && <Checkbox checked={value} disabled={disabled} readOnly />
}
rightSection={
switchMode && (
<Switch
// Switch requires onClick to be passed in, while Checkbox doesn't
onClick={toggle}
checked={value}
disabled={disabled}
withThumbIndicator={false}
/>
Comment thread
naanci marked this conversation as resolved.
Comment thread
angelayu0530 marked this conversation as resolved.
: <Checkbox checked={value} disabled={disabled} readOnly />
)
}
>
<div
Expand Down
Loading