feat: Port tests from libDispatch to DispatchAsync. Add additional tests for functionality. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottmarchant
commented
Jul 9, 2025
scottmarchant
requested review from
NeedleInAJayStack,
Austinpayne and
CrownedPhoenix
33 tasks
scottmarchant
commented
Aug 8, 2025
JaapWijnen
approved these changes
Aug 11, 2025
scottmarchant
force-pushed
the
feat/addAdditionalTests
branch
from
ae42424 to
a872ad4
Compare
clackary
approved these changes
Sep 23, 2025
CrownedPhoenix
approved these changes
Sep 24, 2025
scottmarchant
force-pushed
the
feat/addAdditionalTests
branch
from
a872ad4 to
ee96d84
Compare
[Human-Directed AI Assistance]
…/tests/dispatch_pingpong.c. [Human-Directed AI Assistance]
# Conflicts: # Tests/DispatchAsyncTests/DispatchGroupTests.swift # Conflicts: # Tests/DispatchAsyncTests/DispatchGroupTests.swift
…And other minor improvements to tests.
scottmarchant
force-pushed
the
feat/addAdditionalTests
branch
from
ee96d84 to
7331fb6
Compare
scottmarchant
changed the title
scottmarchant
commented
Sep 30, 2025
| let group = DispatchGroup() | ||
| await result.append(value: "|🔵\(index)") | ||
| let group = DispatchGroup() | ||
| await result.append(value: "|🔵\(iteration)") |
There was a problem hiding this comment.
Ah, interesting. Compiler error caused by this change. Something in the rebase and merged didn't flag this as a conflict, and interestingly enough the CI didn't run on this PR after re-targeting the stacked PR to main. Will fix soon, and will check that a normal PR runs the expected checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick summary
This PR adds a focused round of new and ported tests to harden the experimental
DispatchAsyncpackage:AsyncSemaphoreandDispatchTimeIntervalcover edge-cases that weren’t exercised before.dispatch_pingponganddispatch_group) rewritten in Swift to stress-test queue/group behaviour under concurrency.DispatchGroup.waitpublicly visible so the new tests compile.PR Dependencies
This branch is stacked on PR #1 – “Initial implementation of many GCD API’s using Swift Concurrency.”
PR #1 will need merged before this PR.