the preview image size in tables has been adjusted for better visibility #623
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Honestly, I find the images too big that way and the tables become very long unnecessarily.
We can build in an option to have larger preview images, but that should be configurable. And for that it is probably the best to wait for the new settings system, I am working on. |
The hoverpic min-width and max-width are now the same size, to improve the preview image size on mobile phones.
|
I understand your point that the table becomes too long with too large a image. The idea of changing the image size via the settings is great. But I think the min-width of 10px is too small, you can't see anything on the small preview images. I noticed this especially on my smartphone (Samsung S10 with Chrome). Personally, I think a width of 30px is nicer. This is what it looks like with 10px: This is what it looks like with 30px: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before
after
