Merged
Conversation
… going to be applied.
… going to be applied.
… and adding a reflectatsurface kernel
for more information, see https://pre-commit.ci
Pull main branch into optimise_kernels branch.
VeckoTheGecko
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we add a few new kernels (for reflective boundary conditions and unbeaching without an unbeaching field), as well as partly optimise the Stokes drift and windage drift kernels (so that velocity field sampling only occurs if the particle should be moving).
This PR also solves #61, and provides a new kernel that only relies on the 2D velocity field for unbeaching.