Create example_Initialise_JIT_particles_with_initial_values.py#1
Create example_Initialise_JIT_particles_with_initial_values.py#1HaydenSchilling wants to merge 3 commits intoParcels-code:masterfrom
Conversation
This example shows how to create a particle set in JIT mode while still sampling initial conditions of a variable eg. Temperature. This is an example of a solution to the github issue here: Parcels-code/Parcels#861
removed reference to a variable not in this example (previous lat and lon)
erikvansebille
left a comment
There was a problem hiding this comment.
Thanks ofr contributing, @HaydenSchilling. A few minor comments below
| # Excute the code | ||
| pset.execute(kernels, | ||
| dt=delta(minutes=30), | ||
| output_file=pfile, | ||
| verbose_progress=True, | ||
| #moviedt=delta(hours=1), | ||
| runtime = runtime, | ||
| recovery={ErrorCode.ErrorOutOfBounds: DeleteParticle}) | ||
| pfile.close() No newline at end of file |
There was a problem hiding this comment.
Not sure this part of the script is needed. Since you've defined the kernels above, users can use them in their own pset.execute()
There was a problem hiding this comment.
ah, that makes sense, thanks. I've now removed this bit.
| def SampleInitial(particle, fieldset, time): | ||
| if particle.sampled == 0: | ||
| particle.temp = fieldset.temp[time, particle.depth, particle.lat, particle.lon] | ||
| particle.sampled = 1 |
There was a problem hiding this comment.
Does this actually mean that the temperature at time=0 is also written to the ParticleFile?
There was a problem hiding this comment.
It was suppose to... but looking closer it appears it does not to.
I originally checked it looking at distance calulations in another script. The calculations worked with this method (using a prev_lat variable --- Did not work without this kernel) but looking closer it is calculating these initial values but not recording them in the particle file for any variable. This might need some more work. Sorry.
remove execution lines. Add a note that is is not recording the day 0 data in the particle set
This example shows how to create a particle set in JIT mode while still sampling initial conditions of a variable eg. Temperature.
This is an example of a solution to the github issue here: Parcels-code/Parcels#861 and I am attempting to contribute this example as I recently applied it in my own code based upon suggestions in that issue thread.
Note: This is my first attempt at a contribution so please let me know if I am suppose to do anything else for a contribution.