Merged
Conversation
To check if that fixes #135. If so, we may want to rename and move the files to a separate directory
VeckoTheGecko
approved these changes
Mar 31, 2025
Contributor
There was a problem hiding this comment.
I think the issue is two-fold, main.js not being in public (fixed here), and also #137, so I propose we wait for that to propagate and see if we can re-create the same bug.
I have amended this PR to delete the svgs added in this PR since they already exist in public/drifters with their references updated (this was changed since the prior site).
Let's squash merge on green
Member
Author
|
OK! And should we then move |
Contributor
|
|
Contributor
|
@erikvansebille if you could double check these and merge when ready :) |
Member
Author
|
Works! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To check if that fixes #135. If so, we may want to rename and move the files to a separate directory