Skip to content

Move driftermap code to /public#136

Merged
erikvansebille merged 3 commits intomainfrom
move_driftermap_code_to_public
Mar 31, 2025
Merged

Move driftermap code to /public#136
erikvansebille merged 3 commits intomainfrom
move_driftermap_code_to_public

Conversation

@erikvansebille
Copy link
Copy Markdown
Member

To check if that fixes #135. If so, we may want to rename and move the files to a separate directory

To check if that fixes #135. If so, we may want to rename and move the files to a separate directory
Copy link
Copy Markdown
Contributor

@VeckoTheGecko VeckoTheGecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issue is two-fold, main.js not being in public (fixed here), and also #137, so I propose we wait for that to propagate and see if we can re-create the same bug.

I have amended this PR to delete the svgs added in this PR since they already exist in public/drifters with their references updated (this was changed since the prior site).

Let's squash merge on green

@erikvansebille
Copy link
Copy Markdown
Member Author

OK! And should we then move main.js also to /public/drifters, and perhaps rename it to driftermap.js?

@VeckoTheGecko
Copy link
Copy Markdown
Contributor

VeckoTheGecko commented Mar 31, 2025

Ah! Turns out we already have main.js in drifters. I think that having public/drifters/main.js is clear. Will update accordingly now

@VeckoTheGecko
Copy link
Copy Markdown
Contributor

@erikvansebille if you could double check these and merge when ready :)

@erikvansebille erikvansebille merged commit 085224e into main Mar 31, 2025
3 checks passed
@erikvansebille erikvansebille deleted the move_driftermap_code_to_public branch March 31, 2025 12:17
@erikvansebille
Copy link
Copy Markdown
Member Author

Works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drifter maps not working

2 participants