Support deprecation of attributes and attribute values#390
Open
Support deprecation of attributes and attribute values#390
Conversation
Member
|
Failing on installation with: debugging now. |
zbeekman
added a commit
that referenced
this pull request
Mar 11, 2026
Adopt the approach from PR #390 (by Samuel Khuvis): model attribute definitions can include a 'deprecated' key mapping values to (deprecated_version, removed_version) tuples keyed to upstream TAU versions. Experiment.verify() checks all component attributes against the installed TAU version and raises ConfigurationError for removed values or logs a warning for deprecated ones. Applied to ompt_source: download-tr4 and download-tr6 marked as deprecated in TAU 2.29.1 and removed in TAU 2.32. Also adds TauInstallation.get_tau_version() for reading the upstream TAU version from installed headers, and stores tau_version in experiment records. Bug fixes vs original PR #390: Python 3 .items(), correct variable references, proper error handling in get_tau_version(), returns version tuple for comparison. Co-authored-by: Samuel Khuvis <samuel.khuvis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on issue #381. We just need to add a deprecated option to the option that has been deprecated/removed. Either a string or a list can be passed in. Then once it has been removed add a second element to the string, i.e.:
ompt_source: {
...
'deprecated': {'download-tr4': '2.29.1'},
'deprecated': {'download-tr4': ['2.29.1']},
'deprecated': {'download-tr4': ['2.29.1', '']},
'deprecated': {'download-tr4': ['2.29.1', <removed tau version>]},
...
}