Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Upstream (BungeeCord) #834

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Conversation

NoahvdAa
Copy link
Member

@NoahvdAa NoahvdAa commented Dec 5, 2023

Upstream has released updates that appear to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing

BungeeCord Changes:
8ce7a7f8 Minecraft 1.20.3 support
e1462ccd Minecraft 1.20.3-rc1 support
70f346c1 Fix extra write in ScoreboardScore packet 197bf13a Minecraft 1.20.3-pre2 support

Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

BungeeCord Changes:
8ce7a7f8 Minecraft 1.20.3 support
e1462ccd Minecraft 1.20.3-rc1 support
70f346c1 Fix extra write in ScoreboardScore packet
197bf13a Minecraft 1.20.3-pre2 support
@NoahvdAa
Copy link
Member Author

NoahvdAa commented Dec 5, 2023

Actually did a smoke test this time, seems to work fine ;)

@electronicboy
Copy link
Member

ty, I'd started this locally but am half dead

@electronicboy electronicboy merged commit 24b7e51 into PaperMC:master Dec 5, 2023
@NoahvdAa NoahvdAa deleted the update/1.20.3 branch December 5, 2023 18:32
@Ceddix
Copy link

Ceddix commented Dec 5, 2023

I'm getting following error since I updated to this build. There seem to be some outages on Mojang servers rn BUT the players who get the error can still join on other servers.

[23:42:49] [Netty Worker IO Thread #27/ERROR]: Error authenticating Ashia with minecraft.net
io.netty.resolver.dns.DnsResolveContext$SearchDomainUnknownHostException: Failed to resolve 'sessionserver.mojang.com' [A(1)] and search domain query for configured domains failed as well: [dus4.fastwebserver.de]
	at io.netty.resolver.dns.DnsResolveContext.finishResolve(DnsResolveContext.java:1097) ~[latest.waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:00122d2:555]
	at io.netty.resolver.dns.DnsResolveContext.tryToFinishResolve(DnsResolveContext.java:1044) ~[latest.waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:00122d2:555]
	at io.netty.resolver.dns.DnsResolveContext.query(DnsResolveContext.java:432) ~[latest.waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:00122d2:555]
	at io.netty.resolver.dns.DnsResolveContext.access$700(DnsResolveContext.java:66) ~[latest.waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:00122d2:555]
	at io.netty.resolver.dns.DnsResolveContext$2.operationComplete(DnsResolveContext.java:500) ~[latest.waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:00122d2:555]
	at io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:590) ~[latest.waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:00122d2:555]
	at io.netty.util.concurrent.DefaultPromise.notifyListeners0(DefaultPromise.java:583) ~[latest.waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:00122d2:555]
	at io.netty.util.concurrent.DefaultPromise.notifyListenersNow(DefaultPromise.java:559) ~[latest.waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:00122d2:555]
	at io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:492) ~[latest.waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:00122d2:555]
	at io.netty.util.concurrent.DefaultPromise.setValue0(DefaultPromise.java:636) ~[latest.waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:00122d2:555]
	at io.netty.util.concurrent.DefaultPromise.setFailure0(DefaultPromise.java:629) ~[latest.waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:00122d2:555]
	at io.netty.util.concurrent.DefaultPromise.tryFailure(DefaultPromise.java:118) ~[latest.waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:00122d2:555]
	at io.netty.resolver.dns.DnsQueryContext.finishFailure(DnsQueryContext.java:348) ~[latest.waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:00122d2:555]
	at io.netty.resolver.dns.DnsQueryContext$5.run(DnsQueryContext.java:290) ~[latest.waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:00122d2:555]
	at io.netty.util.concurrent.PromiseTask.runTask(PromiseTask.java:98) ~[latest.waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:00122d2:555]
	at io.netty.util.concurrent.ScheduledFutureTask.run(ScheduledFutureTask.java:153) ~[latest.waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:00122d2:555]
	at io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:173) ~[latest.waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:00122d2:555]
	at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:166) ~[latest.waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:00122d2:555]
	at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:470) ~[latest.waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:00122d2:555]
	at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:416) ~[latest.waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:00122d2:555]
	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) ~[latest.waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:00122d2:555]
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[latest.waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:00122d2:555]
	at java.lang.Thread.run(Thread.java:833) [?:?]
Caused by: io.netty.resolver.dns.DnsNameResolverTimeoutException: [39147: /127.0.0.53:53] DefaultDnsQuestion(sessionserver.mojang.com. IN A) query '39147' via UDP timed out after 5000 milliseconds (no stack trace available)

The players get the "You are already connected to this server" error message.

@Janmm14
Copy link
Contributor

Janmm14 commented Dec 5, 2023

@Ceddix Try to disable netty dns resolver setting (waterfall setting).

to me this looks like pure coincidence that it happenend with you upgrading to this build of waterfall

@Ceddix
Copy link

Ceddix commented Dec 6, 2023

@Janmm14 Changed it, but some players still get the error and can't join. But if it isn't related to the update, I should probably ask on Discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants