Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended Information-forwarding support #663

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Extended Information-forwarding support #663

wants to merge 2 commits into from

Conversation

Xernium
Copy link
Contributor

@Xernium Xernium commented Jun 25, 2021 •
edited
Loading

This PR brings Waterfall on a forwarding-feature-level with Velocity for better security.
Implemented:

  • Velocity modern forwarding support, courtesy of @astei and the Velocity contributors, this forwarding mode uses a 1.13 and newer feature for a more standardised and less volatile forwarding solution.
  • Bungeeguard forwarding support (natively), courtesy of @lucko this forwarding type is an extension to the standard/legacy Bungeecord forwarding protocol which adds another field/token for authentication.

This PR is soon to be accompanied by a PR to update the PaperMC/PaperDocs with information on all of this

electronicboy
electronicboy approved these changes Oct 7, 2021
View reviewed changes
BungeeCord-Patches/0061-Rework-information-forwarding.patch
Preconditions.checkNotNull( desc.getName(), "Plugin from %s has no name", file );
Preconditions.checkNotNull( desc.getMain(), "Plugin from %s has no main", file );

+ // Waterfall start: Forwarding rework
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I err on this, no idea if others have any other thoughts on this, I mean, it makes sense but I don't want this to become a norm in any form of the sense

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's any help, I'd happily accept a PR in BungeeGuard that implements this the other way around :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, that would probs be nicer, just feels a bit "shameful" like this, and I don't wanna set the means for that oddball slippy slope of "shaming" plugins <3

@xism4 xism4 mentioned this pull request Jul 8, 2023
Closed
@electronicboy electronicboy self-assigned this Oct 12, 2023
@electronicboy
Copy link
Member

I kinda want this, just solely because I can't be arsed breaking my setup to test waterfall cruddery, there was a linked PR which is closed now, which I have no idea where that derives from, etc, etc; is there any interest in updating this, if Luck has no issues, in good faith, we can probably keep the message as-is

@xism4
Copy link
Contributor

xism4 commented Oct 13, 2023

I kinda want this, just solely because I can't be arsed breaking my setup to test waterfall cruddery, there was a linked PR which is closed now, which I have no idea where that derives from, etc, etc; is there any interest in updating this, if Luck has no issues, in good faith, we can probably keep the message as-is

The PR it's same as here but without that excesive log and higher version support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucko lucko lucko left review comments

@electronicboy electronicboy electronicboy approved these changes

Assignees

@electronicboy electronicboy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xernium @electronicboy @xism4 @lucko