Skip to content

Commit

Permalink
Updated Upstream (BungeeCord)
Browse files Browse the repository at this point in the history
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

BungeeCord Changes:
c92581d0 #3556: Deserialize arrays to single components
e442c3da #3546: Add string length checks to isValidName
f903c54d #3554: Bump org.apache.maven.plugins:maven-checkstyle-plugin
0d453789 #3540: Add TextComponent#fromLegacy() as an array-free alternative to #fromLegacyText()
0f5f09b6 Minecraft 23w43b support
e5c80d00 Fix code formatting
9cdb2ba3 Deprecate exposed scoreboard API
d0e5cf7c #3549: Bump io.netty:netty-bom from 4.1.99.Final to 4.1.100.Final
c8568764 Fix writing non-compound root NBT tags
  • Loading branch information
electronicboy committed Oct 29, 2023
1 parent 6dd7600 commit dc05956
Show file tree
Hide file tree
Showing 25 changed files with 155 additions and 146 deletions.
2 changes: 1 addition & 1 deletion BungeeCord
Submodule BungeeCord updated 46 files
+3 −3 api/src/main/java/net/md_5/bungee/api/ServerPing.java
+3 −0 api/src/main/java/net/md_5/bungee/api/connection/ProxiedPlayer.java
+24 −11 api/src/main/java/net/md_5/bungee/api/event/LoginEvent.java
+24 −11 api/src/main/java/net/md_5/bungee/api/event/PreLoginEvent.java
+41 −4 api/src/main/java/net/md_5/bungee/api/event/ServerKickEvent.java
+4 −4 chat/src/main/java/net/md_5/bungee/api/chat/ComponentBuilder.java
+1 −1 chat/src/main/java/net/md_5/bungee/api/chat/ItemTag.java
+72 −5 chat/src/main/java/net/md_5/bungee/api/chat/TextComponent.java
+4 −1 chat/src/main/java/net/md_5/bungee/api/chat/hover/content/Text.java
+44 −15 chat/src/main/java/net/md_5/bungee/chat/ComponentSerializer.java
+2 −3 chat/src/main/java/net/md_5/bungee/chat/TextComponentSerializer.java
+7 −7 chat/src/test/java/net/md_5/bungee/api/chat/ComponentsTest.java
+1 −1 module/cmd-alert/src/main/java/net/md_5/bungee/module/cmd/alert/CommandAlert.java
+3 −3 module/cmd-kick/src/main/java/net/md_5/bungee/module/cmd/kick/CommandKick.java
+2 −2 pom.xml
+6 −12 protocol/pom.xml
+55 −1 protocol/src/main/java/net/md_5/bungee/protocol/DefinedPacket.java
+1 −1 protocol/src/main/java/net/md_5/bungee/protocol/MinecraftDecoder.java
+1 −1 protocol/src/main/java/net/md_5/bungee/protocol/MinecraftEncoder.java
+4 −2 protocol/src/main/java/net/md_5/bungee/protocol/Protocol.java
+2 −1 protocol/src/main/java/net/md_5/bungee/protocol/ProtocolConstants.java
+218 −0 protocol/src/main/java/net/md_5/bungee/protocol/TagUtil.java
+2 −1 protocol/src/main/java/net/md_5/bungee/protocol/Varint21LengthFieldExtraBufPrepender.java
+2 −1 protocol/src/main/java/net/md_5/bungee/protocol/Varint21LengthFieldPrepender.java
+6 −5 protocol/src/main/java/net/md_5/bungee/protocol/packet/BossBar.java
+21 −5 protocol/src/main/java/net/md_5/bungee/protocol/packet/Kick.java
+7 −6 protocol/src/main/java/net/md_5/bungee/protocol/packet/PlayerListHeaderFooter.java
+6 −5 protocol/src/main/java/net/md_5/bungee/protocol/packet/PlayerListItem.java
+2 −2 protocol/src/main/java/net/md_5/bungee/protocol/packet/PlayerListItemUpdate.java
+4 −3 protocol/src/main/java/net/md_5/bungee/protocol/packet/ScoreboardObjective.java
+4 −3 protocol/src/main/java/net/md_5/bungee/protocol/packet/ServerData.java
+4 −3 protocol/src/main/java/net/md_5/bungee/protocol/packet/Subtitle.java
+4 −3 protocol/src/main/java/net/md_5/bungee/protocol/packet/SystemChat.java
+20 −6 protocol/src/main/java/net/md_5/bungee/protocol/packet/TabCompleteResponse.java
+14 −13 protocol/src/main/java/net/md_5/bungee/protocol/packet/Team.java
+6 −5 protocol/src/main/java/net/md_5/bungee/protocol/packet/Title.java
+3 −3 proxy/src/main/java/net/md_5/bungee/BungeeCord.java
+6 −22 proxy/src/main/java/net/md_5/bungee/BungeeTitle.java
+6 −2 proxy/src/main/java/net/md_5/bungee/ServerConnector.java
+28 −39 proxy/src/main/java/net/md_5/bungee/UserConnection.java
+10 −7 proxy/src/main/java/net/md_5/bungee/connection/DownstreamBridge.java
+12 −16 proxy/src/main/java/net/md_5/bungee/connection/InitialHandler.java
+2 −0 proxy/src/main/java/net/md_5/bungee/entitymap/EntityMap.java
+1 −0 proxy/src/main/java/net/md_5/bungee/entitymap/EntityMap_1_16_2.java
+5 −0 proxy/src/main/java/net/md_5/bungee/util/AllowedCharacters.java
+28 −38 proxy/src/main/java/net/md_5/bungee/util/ChatComponentTransformer.java
14 changes: 7 additions & 7 deletions BungeeCord-Patches/0001-POM-Changes.patch
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From d002f1654018a69fdee68237fff9aa1442363bc2 Mon Sep 17 00:00:00 2001
From 3b1984106e3bfd5e2504ae84797ec65d8a8dca42 Mon Sep 17 00:00:00 2001
From: Tux <[email protected]>
Date: Thu, 19 May 2016 19:33:31 +0200
Subject: [PATCH] POM Changes
Expand Down Expand Up @@ -68,7 +68,7 @@ index 30739518..bdccbd78 100644
<scope>compile</scope>
</dependency>
diff --git a/bootstrap/pom.xml b/bootstrap/pom.xml
index b10e7a38..07d49112 100644
index 2b80f83b..fc09cc11 100644
--- a/bootstrap/pom.xml
+++ b/bootstrap/pom.xml
@@ -4,39 +4,40 @@
Expand Down Expand Up @@ -515,7 +515,7 @@ index a4265e54..5e9d29d7 100644
<dependencies>
<dependency>
diff --git a/pom.xml b/pom.xml
index ed3c1a87..a6684b7c 100644
index 9725c974..3a72aa08 100644
--- a/pom.xml
+++ b/pom.xml
@@ -3,18 +3,25 @@
Expand Down Expand Up @@ -633,7 +633,7 @@ index ed3c1a87..a6684b7c 100644
+ <plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>3.3.0</version>
<version>3.3.1</version>
@@ -173,6 +197,7 @@
</dependency>
</dependencies>
Expand Down Expand Up @@ -667,7 +667,7 @@ index ed3c1a87..a6684b7c 100644
</execution>
</executions>
diff --git a/protocol/pom.xml b/protocol/pom.xml
index f1c169a9..12096614 100644
index 4d611101..76a3510d 100644
--- a/protocol/pom.xml
+++ b/protocol/pom.xml
@@ -4,19 +4,19 @@
Expand All @@ -694,9 +694,9 @@ index f1c169a9..12096614 100644
+ <name>Waterfall-Protocol</name>
+ <description>Minimal implementation of the Minecraft protocol for use in Waterfall</description>

<!-- We really shouldn't depend on external repositories, but at least this is the Central staging one -->
<!-- We really shouldn't depend on external repositories -->
<repositories>
@@ -41,8 +41,8 @@
@@ -35,8 +35,8 @@
<scope>compile</scope>
</dependency>
<dependency>
Expand Down
6 changes: 3 additions & 3 deletions BungeeCord-Patches/0007-Fixup-ProtocolConstants.patch
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
From d86bb6401198008a6cc41ab73ebd1f253322ff7c Mon Sep 17 00:00:00 2001
From 6420147c00011f92af85e62463d3a88048b96d32 Mon Sep 17 00:00:00 2001
From: Troy Frew <[email protected]>
Date: Tue, 15 Nov 2016 09:07:51 -0500
Subject: [PATCH] Fixup ProtocolConstants


diff --git a/protocol/src/main/java/net/md_5/bungee/protocol/ProtocolConstants.java b/protocol/src/main/java/net/md_5/bungee/protocol/ProtocolConstants.java
index 7d5e2635..a0dd9be6 100644
index d92a66d9..fedf6e99 100644
--- a/protocol/src/main/java/net/md_5/bungee/protocol/ProtocolConstants.java
+++ b/protocol/src/main/java/net/md_5/bungee/protocol/ProtocolConstants.java
@@ -114,6 +114,16 @@ public class ProtocolConstants
@@ -115,6 +115,16 @@ public class ProtocolConstants
SUPPORTED_VERSION_IDS = supportedVersionIds.build();
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From 8c8b25883c768d798456d7289d057275d790b677 Mon Sep 17 00:00:00 2001
From eb1f1b27dbbd6f6831b35c21ecfb2cfe4a675da1 Mon Sep 17 00:00:00 2001
From: Techcable <[email protected]>
Date: Tue, 3 May 2016 20:31:52 -0700
Subject: [PATCH] Don't access a ByteBuf's underlying array
Expand Down Expand Up @@ -43,10 +43,10 @@ index 70b292f0..91f71c09 100644
* Allow this packet to be sent as an "extended" packet.
*/
diff --git a/proxy/src/main/java/net/md_5/bungee/ServerConnector.java b/proxy/src/main/java/net/md_5/bungee/ServerConnector.java
index 409464d2..76db3a71 100644
index 5ca53d81..4f1011b9 100644
--- a/proxy/src/main/java/net/md_5/bungee/ServerConnector.java
+++ b/proxy/src/main/java/net/md_5/bungee/ServerConnector.java
@@ -265,7 +265,7 @@ public class ServerConnector extends PacketHandler
@@ -266,7 +266,7 @@ public class ServerConnector extends PacketHandler

ByteBuf brand = ByteBufAllocator.DEFAULT.heapBuffer();
DefinedPacket.writeString( bungee.getName() + " (" + bungee.getVersion() + ")", brand );
Expand All @@ -56,7 +56,7 @@ index 409464d2..76db3a71 100644
}

diff --git a/proxy/src/main/java/net/md_5/bungee/connection/DownstreamBridge.java b/proxy/src/main/java/net/md_5/bungee/connection/DownstreamBridge.java
index 117ebb76..b8248ec4 100644
index 8f955fdc..3ff8e553 100644
--- a/proxy/src/main/java/net/md_5/bungee/connection/DownstreamBridge.java
+++ b/proxy/src/main/java/net/md_5/bungee/connection/DownstreamBridge.java
@@ -300,7 +300,7 @@ public class DownstreamBridge extends PacketHandler
Expand Down
8 changes: 4 additions & 4 deletions BungeeCord-Patches/0010-Optimize-uuid-conversions.patch
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From f2c91fe1c64c1b9d468063c57165a808be7235e1 Mon Sep 17 00:00:00 2001
From 1668e9e6e23ce2d43df05c7d496cdd086cadd4b9 Mon Sep 17 00:00:00 2001
From: Techcable <[email protected]>
Date: Mon, 14 Mar 2016 15:40:44 -0700
Subject: [PATCH] Optimize uuid conversions
Expand Down Expand Up @@ -237,7 +237,7 @@ index 6352951c..91efc0a6 100644

/**
diff --git a/api/src/main/java/net/md_5/bungee/api/ServerPing.java b/api/src/main/java/net/md_5/bungee/api/ServerPing.java
index 88d36ad2..fc92a7b5 100644
index e582808f..29cd91dd 100644
--- a/api/src/main/java/net/md_5/bungee/api/ServerPing.java
+++ b/api/src/main/java/net/md_5/bungee/api/ServerPing.java
@@ -74,7 +74,7 @@ public class ServerPing
Expand All @@ -250,10 +250,10 @@ index 88d36ad2..fc92a7b5 100644
}

diff --git a/proxy/src/main/java/net/md_5/bungee/connection/InitialHandler.java b/proxy/src/main/java/net/md_5/bungee/connection/InitialHandler.java
index 09080f36..14a34f99 100644
index 0bcbc8fb..6562a641 100644
--- a/proxy/src/main/java/net/md_5/bungee/connection/InitialHandler.java
+++ b/proxy/src/main/java/net/md_5/bungee/connection/InitialHandler.java
@@ -722,7 +722,7 @@ public class InitialHandler extends PacketHandler implements PendingConnection
@@ -718,7 +718,7 @@ public class InitialHandler extends PacketHandler implements PendingConnection
@Override
public String getUUID()
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From 0a7710b54fbc938b1913070090ebeb7b6e3bdd5f Mon Sep 17 00:00:00 2001
From d8cc33712c4b60c77f3a9c793f90c85a9a9f2d74 Mon Sep 17 00:00:00 2001
From: Daniel Naylor <[email protected]>
Date: Tue, 25 Oct 2016 12:23:07 -0400
Subject: [PATCH] Add support for FML with IP Forwarding enabled
Expand All @@ -12,7 +12,7 @@ However, there is now at least one Forge coremod that intends to support IP forw
No breaking changes occur due to this patch.

diff --git a/proxy/src/main/java/net/md_5/bungee/ServerConnector.java b/proxy/src/main/java/net/md_5/bungee/ServerConnector.java
index 76db3a71..3aacebe1 100644
index 4f1011b9..8a57c5a8 100644
--- a/proxy/src/main/java/net/md_5/bungee/ServerConnector.java
+++ b/proxy/src/main/java/net/md_5/bungee/ServerConnector.java
@@ -7,6 +7,7 @@ import io.netty.buffer.ByteBufAllocator;
Expand All @@ -23,7 +23,7 @@ index 76db3a71..3aacebe1 100644
import java.util.Queue;
import java.util.Set;
import java.util.UUID;
@@ -109,15 +110,39 @@ public class ServerConnector extends PacketHandler
@@ -110,15 +111,39 @@ public class ServerConnector extends PacketHandler
String newHost = copiedHandshake.getHost() + "\00" + AddressUtil.sanitizeAddress( user.getAddress() ) + "\00" + user.getUUID();

LoginResult profile = user.getPendingConnection().getLoginProfile();
Expand Down Expand Up @@ -67,7 +67,7 @@ index 76db3a71..3aacebe1 100644
}

diff --git a/proxy/src/main/java/net/md_5/bungee/UserConnection.java b/proxy/src/main/java/net/md_5/bungee/UserConnection.java
index be65c3ad..6ca259cb 100644
index 18b1690d..db103d32 100644
--- a/proxy/src/main/java/net/md_5/bungee/UserConnection.java
+++ b/proxy/src/main/java/net/md_5/bungee/UserConnection.java
@@ -170,8 +170,12 @@ public final class UserConnection implements ProxiedPlayer
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From ff46baa5671121531007c00dc684dc035a16dd8c Mon Sep 17 00:00:00 2001
From dde015048a91f44a859189f590147b9244de3f80 Mon Sep 17 00:00:00 2001
From: Techcable <[email protected]>
Date: Thu, 19 May 2016 17:09:22 -0600
Subject: [PATCH] Allow invalid packet ids for forge servers
Expand All @@ -9,7 +9,7 @@ Vanilla servers still error on negative/invalid packets.
Original issue: https://github.com/WaterfallMC/Waterfall-Old/issues/11

diff --git a/protocol/src/main/java/net/md_5/bungee/protocol/MinecraftDecoder.java b/protocol/src/main/java/net/md_5/bungee/protocol/MinecraftDecoder.java
index 482341ef..76a3ddd0 100644
index d79d5e5c..250e7620 100644
--- a/protocol/src/main/java/net/md_5/bungee/protocol/MinecraftDecoder.java
+++ b/protocol/src/main/java/net/md_5/bungee/protocol/MinecraftDecoder.java
@@ -18,6 +18,14 @@ public class MinecraftDecoder extends MessageToMessageDecoder<ByteBuf>
Expand All @@ -35,12 +35,12 @@ index 482341ef..76a3ddd0 100644
+ DefinedPacket packet = prot.createPacket( packetId, protocolVersion, supportsForge );
if ( packet != null )
{
packet.read( in, prot.getDirection(), protocolVersion );
packet.read( in, protocol, prot.getDirection(), protocolVersion );
diff --git a/protocol/src/main/java/net/md_5/bungee/protocol/Protocol.java b/protocol/src/main/java/net/md_5/bungee/protocol/Protocol.java
index b6985fee..7f001b11 100644
index 2eeca50b..9bd62ceb 100644
--- a/protocol/src/main/java/net/md_5/bungee/protocol/Protocol.java
+++ b/protocol/src/main/java/net/md_5/bungee/protocol/Protocol.java
@@ -749,14 +749,23 @@ public enum Protocol
@@ -751,14 +751,23 @@ public enum Protocol
return protocol;
}

Expand All @@ -66,10 +66,10 @@ index b6985fee..7f001b11 100644
throw new BadPacketException( "Packet with id " + id + " outside of range" );
}
diff --git a/proxy/src/main/java/net/md_5/bungee/ServerConnector.java b/proxy/src/main/java/net/md_5/bungee/ServerConnector.java
index 3aacebe1..a5c8de90 100644
index 8a57c5a8..b856647f 100644
--- a/proxy/src/main/java/net/md_5/bungee/ServerConnector.java
+++ b/proxy/src/main/java/net/md_5/bungee/ServerConnector.java
@@ -34,7 +34,9 @@ import net.md_5.bungee.forge.ForgeUtils;
@@ -35,7 +35,9 @@ import net.md_5.bungee.forge.ForgeUtils;
import net.md_5.bungee.netty.ChannelWrapper;
import net.md_5.bungee.netty.HandlerBoss;
import net.md_5.bungee.netty.PacketHandler;
Expand All @@ -79,7 +79,7 @@ index 3aacebe1..a5c8de90 100644
import net.md_5.bungee.protocol.PacketWrapper;
import net.md_5.bungee.protocol.Protocol;
import net.md_5.bungee.protocol.ProtocolConstants;
@@ -222,6 +224,12 @@ public class ServerConnector extends PacketHandler
@@ -223,6 +225,12 @@ public class ServerConnector extends PacketHandler
public static void handleLogin(ProxyServer bungee, ChannelWrapper ch, UserConnection user, BungeeServerInfo target, ForgeServerHandler handshakeHandler, ServerConnection server, Login login) throws Exception
{
ServerConnectedEvent event = new ServerConnectedEvent( user, server );
Expand All @@ -93,10 +93,10 @@ index 3aacebe1..a5c8de90 100644

ch.write( BungeeCord.getInstance().registerChannels( user.getPendingConnection().getVersion() ) );
diff --git a/proxy/src/main/java/net/md_5/bungee/entitymap/EntityMap.java b/proxy/src/main/java/net/md_5/bungee/entitymap/EntityMap.java
index 30cc36a4..c033118f 100644
index 9a47f2ec..b768d54a 100644
--- a/proxy/src/main/java/net/md_5/bungee/entitymap/EntityMap.java
+++ b/proxy/src/main/java/net/md_5/bungee/entitymap/EntityMap.java
@@ -338,6 +338,12 @@ public abstract class EntityMap
@@ -340,6 +340,12 @@ public abstract class EntityMap
int packetId = DefinedPacket.readVarInt( packet );
int packetIdLength = packet.readerIndex() - readerIndex;

Expand Down
14 changes: 7 additions & 7 deletions BungeeCord-Patches/0018-Improve-server-list-ping-logging.patch
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From e8ea9698ec9af3d3ccc6be444b8a604aae29041a Mon Sep 17 00:00:00 2001
From 74fc5e424568249619d3e514a21a7574978435e1 Mon Sep 17 00:00:00 2001
From: Janmm14 <[email protected]>
Date: Sat, 12 Dec 2015 23:43:30 +0100
Subject: [PATCH] Improve server list ping logging
Expand All @@ -7,10 +7,10 @@ This functionality of this patch was adopted upstream, however, this
patch remains for a few misc improvements around here

diff --git a/proxy/src/main/java/net/md_5/bungee/ServerConnector.java b/proxy/src/main/java/net/md_5/bungee/ServerConnector.java
index a5c8de90..59403052 100644
index b856647f..7f1992df 100644
--- a/proxy/src/main/java/net/md_5/bungee/ServerConnector.java
+++ b/proxy/src/main/java/net/md_5/bungee/ServerConnector.java
@@ -499,6 +499,6 @@ public class ServerConnector extends PacketHandler
@@ -503,6 +503,6 @@ public class ServerConnector extends PacketHandler
@Override
public String toString()
{
Expand All @@ -19,10 +19,10 @@ index a5c8de90..59403052 100644
}
}
diff --git a/proxy/src/main/java/net/md_5/bungee/connection/DownstreamBridge.java b/proxy/src/main/java/net/md_5/bungee/connection/DownstreamBridge.java
index 23e7b6d8..88b0156c 100644
index cee4c235..6c545f4c 100644
--- a/proxy/src/main/java/net/md_5/bungee/connection/DownstreamBridge.java
+++ b/proxy/src/main/java/net/md_5/bungee/connection/DownstreamBridge.java
@@ -774,6 +774,6 @@ public class DownstreamBridge extends PacketHandler
@@ -777,6 +777,6 @@ public class DownstreamBridge extends PacketHandler
@Override
public String toString()
{
Expand All @@ -31,10 +31,10 @@ index 23e7b6d8..88b0156c 100644
}
}
diff --git a/proxy/src/main/java/net/md_5/bungee/connection/InitialHandler.java b/proxy/src/main/java/net/md_5/bungee/connection/InitialHandler.java
index 14a34f99..7e2d0c63 100644
index 6562a641..9a6a305b 100644
--- a/proxy/src/main/java/net/md_5/bungee/connection/InitialHandler.java
+++ b/proxy/src/main/java/net/md_5/bungee/connection/InitialHandler.java
@@ -728,20 +728,7 @@ public class InitialHandler extends PacketHandler implements PendingConnection
@@ -724,20 +724,7 @@ public class InitialHandler extends PacketHandler implements PendingConnection
@Override
public String toString()
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From 1b52a13e4834482bb8b9daa3e54556fc2e612668 Mon Sep 17 00:00:00 2001
From 3cebec2175678a2c7351368beffa2b8e09fb4025 Mon Sep 17 00:00:00 2001
From: Techcable <[email protected]>
Date: Sun, 7 Feb 2016 00:01:19 -0700
Subject: [PATCH] Add a property to accept invalid ping packets
Expand All @@ -9,10 +9,10 @@ You can enable it by setting '-Dwaterfall.acceptInvalidPackets=true' at the comm
Fixes #23

diff --git a/proxy/src/main/java/net/md_5/bungee/connection/InitialHandler.java b/proxy/src/main/java/net/md_5/bungee/connection/InitialHandler.java
index 7e2d0c63..9fd951be 100644
index 9a6a305b..300d90f4 100644
--- a/proxy/src/main/java/net/md_5/bungee/connection/InitialHandler.java
+++ b/proxy/src/main/java/net/md_5/bungee/connection/InitialHandler.java
@@ -301,10 +301,14 @@ public class InitialHandler extends PacketHandler implements PendingConnection
@@ -300,10 +300,14 @@ public class InitialHandler extends PacketHandler implements PendingConnection
thisState = State.PING;
}

Expand Down
Loading

0 comments on commit dc05956

Please sign in to comment.