Skip to content

Conversation

@orang3i
Copy link

@orang3i orang3i commented Nov 30, 2025

fixes issue #12487

Currently when a WitherSkull or a LargeFireBall hits a player and the player dies due to its damage the dropped loot is instantly destroyed by the explosion of the projectile.

This PR, delays the death drop by a tick and hence prevents the destruction of loot.

The configuration for this is set to be false by default .

@orang3i orang3i requested a review from a team as a code owner November 30, 2025 17:43
@github-project-automation github-project-automation bot moved this to Awaiting review in Paper PR Queue Nov 30, 2025
@Owen1212055
Copy link
Member

Cant this easily be done by a plugin?

@lynxplay
Copy link
Contributor

lynxplay commented Dec 1, 2025

Well, there is a confirmed mojira bug report out there for it which is why I marked the original issue as accepted.

However, this solution feels too ugly for me to consider it mergable, even behind a config options.
Delaying the drops by a tick is not something I am in favour of, this kind of extra state is screaming for problems.

@orang3i
Copy link
Author

orang3i commented Dec 2, 2025

If no cleaner solution is suggested I will close this PR.

if anyone suggests a better approach, I definitely update the PR accordingly.

@orang3i
Copy link
Author

orang3i commented Dec 2, 2025

I have updated the PR.

This solution seems much simpler, now the explosion doesn't happen if the entity is dead [not alive] instead of delaying the drop by a tick.

@orang3i orang3i changed the title Add configuration for delaying death drops from explosive projectile deaths Add configuration for skipping hurting-projectile explosion when the entity is dead Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Awaiting review

Development

Successfully merging this pull request may close these issues.

3 participants