Use correct addresses for PlayerConnection

[roro1506HD]

getClientAddress() and getAddress() implementations were inverted, this fixes it

[papermc-pr-publishing]

Last updated for: f3f9fb9d3cb241647239a22c046d1a1b87fb278f.

Download the Paperclip jar for this pull request: paper-13307.zip

Maven Publication

The artifacts published by this PR:

• 📦 io.papermc.paper:dev-bundle:1.21.10-R0.1-SNAPSHOT
• 📦 io.papermc.paper:paper-api:1.21.10-R0.1-SNAPSHOT

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven("https://maven-prs.papermc.io/Paper/pr13307") {
        name = "Maven for PR #13307" // https://github.com/PaperMC/Paper/pull/13307
        mavenContent {
            includeModule("io.papermc.paper", "dev-bundle")
            includeModule("io.papermc.paper", "paper-api")
        }
    }
}

[Owen1212055]

this.connection.channel.remoteAddress() can be null, can that be made nullable?

[roro1506HD]

this.connection.channel.remoteAddress() can be null, can that be made nullable?

Can it really be null though? Like when the PaperPlayerLoginConnection object is created, the handshake has already been finished and the connection is already established and as per netty's javadoc, it should only return null if the connection is not yet established

But if you're sure it can be null, then the other method should be nullable as well since it's populated by channel.remoteAddress() when channelActive() is called in the Connection class

[emilyy-dev]

Whilst the method can return true according to the javadoc on various of the Channel subclasses, they all point out that is only the case before the channel can connect to a remote peer, but there is always a remote address due to the flow of operations, it is guaranteed to be non-null.
The same can be said about the handshake-resolved address, and before handshake it gets assigned to the channel address, neither of which points in time are available in the config API.
This looks good to me as it is