Pre-Adventure 5.0 changes #13300
Draft
Pre-Adventure 5.0 changes #13300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezz
force-pushed
the
chore/pre-adventure-5
branch
from
1cc794d to
8a4bb5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes that need to be made before the Adventure 5.0 update.
The following changes are made:
As Adventure's
Bookis now sealed, we need to prepare for this.BookMetaerroneously implements Adventure'sBookso a note is added that this will be removed. The builder will also be deprecated for removal as meta is mutable anyway, so a builder is completely useless. The#toBuildermethod doesn't even work, it just returns an empty builder, so I doubt the builder will be missed.The examination library is removed in Adventure 5.0, so we'll just deprecate this for removal in the one place it is used in Paper.