Add UnsafeValues#deserializeItemHover
#13067
Open
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @Override | ||
| public ItemStack deserializeItemHover(final HoverEvent.ShowItem itemHover) { | ||
| if (itemHover.dataComponents().isEmpty()) { | ||
| return ItemStack.of(Registry.MATERIAL.getOrThrow(itemHover.item()), itemHover.count()); |
There was a problem hiding this comment.
I don't believe this should be using this registry
There was a problem hiding this comment.
Used Material as that's what ItemStack.of takes, should I switch to ItemType with #createItemStack?
And if so, should I switch to the full RegistryAccess.registryAccess().getRegistry() or are the Registry.ITEM constants fine?
There was a problem hiding this comment.
Now uses Registry.ITEM with #createItemStack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
UnsafeValues#deserializeItemHover, to de-serialize an adventureShowIteminto anItemStack.My use case for this is a custom component serializer implementation (similar idea to MiniMessage), that needs to get an
ItemStackinstance for its serialization logic (I'm aware there may be better methods to implement this, but the serializer already exists and is in use with Bungee chat, I'm just migrating it to adventure & need to maintain the exact same format and behavior).See discussion starting at https://discord.com/channels/289587909051416579/555462289851940864/1415331111856508980 (and specifically with lynx at https://discord.com/channels/289587909051416579/555462289851940864/1415336667237060650).
Note
This can throw some exceptions for invalid
ShowItemdata (e.g. usesRegistry#getOrThrow), didn't really bother with that too much as it's anUnsafeValuesuse at your own risk, but let me know if you'd want more specific docs still/to catch them and returnnull.