Flag to inherit access transformers on methods #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful for modifying methods exposed by types with a lot of children to avoid specifying them all.
When inheriting method ATs, classes may need to be processed that are not found in the source AT set as they inherit their ATs from their parent. The previous iteration would accomplish this by simply visiting the entire source root. The commit introduces a simplistic heuristic, filtering out any types from processing that do not have a parent with an AT defined. While this is not exact, e.g. a class will still be processed if its parent type has a field changed via AT, the accesstransformer library used does not expose the types of ATs defined on a class, making this a best effort approximation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for modifying methods exposed by types with a lot of children
to avoid specifying them all.