fix(arena): validate match topic against server-side verification allowlist#3941
Open
ionfwsrijan wants to merge 1 commit into
Open
Conversation
…owlist Only Arrays and Strings topics had verification test cases. Any other topic value from the client bypassed verification completely, allowing a user to claim a win without solving the problem. This change validates the topic against a server-side allowlist and rejects matches for unverified topics. Fixes PankajSingh34#3936
|
@ionfwsrijan is attempting to deploy a commit to the Pankaj singh's projects Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
Author
|
@ezManish Please review this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added server-side topic allowlist to reject match code verification for non-algorithm topics.
Problem
Match code verification only checked for Array/String types but didn't validate the topic. For non-algorithm topics (e.g.,
math,general), verification would incorrectly pass or fail based on type alone.Fix
Added a
VERIFIED_TOPICSset containing topics that support code verification (algorithms,dsa,coding). The server now rejects match requests for topics not in this set, returning a clear error message.Changed
arena-socket-server/index.js: AddedVERIFIED_TOPICSset and validation before accepting match codesFixes #3936