reorganize updateInputFilesStagedAboutIdds_JEDI #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmaeno
reviewed
Nov 12, 2024
There was a problem hiding this comment.
A couple of questions.
- Does "fileid in ()" parform better than executemany?
- I suppose each execution statement with a differnt number of fileids is regarded as unique. Aren't the parsed statement and its execution plan cached, which may increase memory usage on Oracle?
- Wen said idds currently limits the max number of files to 1000 in each message but he still saw the issue. 1000 of executemany is not significant, so I guess the issue is caused by something else than the executemany size. Do you think we really need this change?
|
Another way, we can remove the fileid and scope in the sql when fileid is there. Since it's an 'and' operation between fileid and lfn, all items are executed. when lfn is long, it's not efficient. However, when asking chatgpt, it seems 'fileid in ()' is more efficient than executing multiple updates. |
I made that change in https://github.com/PanDAWMS/panda-jedi/pull/283/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reorganize updateInputFilesStagedAboutIdds_JEDI to use 'fileid in ()', instead of using executeMany.