DF/kafka: try to achieve more smooth app shutdown

When the application stops, it is very rare that it will shutdown all the subprocesses (see Issue #45).
PanDAWMS · Oct 9, 2017 · dd0fb5f · dd0fb5f
1 parent a03865d
commit dd0fb5f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/Utils/Dataflow/000_kafka/ru/kiae/dkb/kafka/common/external/ExternalProcessLogger.java b/Utils/Dataflow/000_kafka/ru/kiae/dkb/kafka/common/external/ExternalProcessLogger.java
@@ -44,10 +44,7 @@ public void run() {
             while ((line = STDERR.readLine()) != null) {
                 external_log(line);
             }
-        } catch (IOException e) {
-            log.error("Failed to read from the process STDERR.");
-            throw new KafkaException(e);
-        }
+        } catch (IOException e) { }
     }
 
     private void external_log(String line) {

diff --git a/...low/000_kafka/ru/kiae/dkb/kafka/streams/processor/external/ExternalProcessorSupplier.java b/...low/000_kafka/ru/kiae/dkb/kafka/streams/processor/external/ExternalProcessorSupplier.java
@@ -157,7 +157,11 @@ public void punctuate(long timestamp) {
             @Override
             public void close() {
                 log.info("Destroying external process.");
-                this.externalProcessor.destroy();
+                try {
+                  this.externalProcessor.destroy();
+                  this.externalProcessor.waitFor(2L, TimeUnit.SECONDS);
+                } catch (InterruptedException int_e) { }
+
             }
 
             public void start() {