Skip to content

Job history limit #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yishaynaPalo merged 6 commits into from
Dec 18, 2025
+10 −2
Merged

Job history limit #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
49beb63
delete finished jobs after 30 minutes
ZurielPalo Dec 15, 2025
d29ab3c
change jobsHistoryLimit to save only last success and failed job
ZurielPalo Dec 15, 2025
b8c56f0
restore chart version
ZurielPalo Dec 16, 2025
a44935d
update chart version
ZurielPalo Dec 17, 2025
d42af57
add ttlSecondsAfterFinished value
ZurielPalo Dec 18, 2025
a8f961f
Merge branch 'release/cloud-1.4' into job-history-limit
yishaynaPalo Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@65d7f2d534ac1bc67fcd62888c5f4f3d2cb2b236 # v4.7.1
with:
python-version: 3.x
python-version: 3.12

- name: Set up chart-testing
uses: helm/chart-testing-action@0d28d3144d3a25ea2cc349d6e59901c4ff469b3b # v2.7.0
Expand Down
2 changes: 1 addition & 1 deletion charts/konnector/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: konnector
description: Deploys Palo Alto Networks' Cortex KSPM connector for advanced Kubernetes security posture management.
type: application
version: 1.0.24-rc.0
version: 1.0.24-rc.1
appVersion: "1.0.0"
maintainers:
- name: Palo Alto Networks - Cortex KSPM team
Expand Down
6 changes: 6 additions & 0 deletions charts/konnector/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,15 @@ app.kubernetes.io/author: {{ .Values.namespace.name }}
{{- printf "%d */1 * * *" $minute -}}
{{- end -}}

{{- define "common.jobsHistoryLimit" -}}
successfulJobsHistoryLimit: 1
failedJobsHistoryLimit: 1
{{- end -}}

{{- define "common.jobTemplate" -}}
spec:
backoffLimit: {{ .Values.system.batch.backoffLimit }}
ttlSecondsAfterFinished: {{ .Values.system.batch.ttlSecondsAfterFinished }}
Copy link
Collaborator

@yishaynaPalo yishaynaPalo Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this value defined?

Copy link
Contributor Author

@ZurielPalo ZurielPalo Dec 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

template:
metadata:
labels:
Expand Down
1 change: 1 addition & 0 deletions charts/konnector/templates/batch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ metadata:
{{- include "common.labels" . | nindent 4 }}
spec:
schedule: {{ include "common.generateSchedule" . | quote }}
{{- include "common.jobsHistoryLimit" . | nindent 2 }}
jobTemplate:
{{- include "common.jobTemplate" . | nindent 4 }}
---
Expand Down
1 change: 1 addition & 0 deletions charts/konnector/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ system:
# ==========================
batch:
backoffLimit: 4 # Maximum number of retries before the job is considered failed. After 4 attempts, the job will fail.
ttlSecondsAfterFinished: 3600 # Time-to-live for completed jobs, jobs will be automatically deleted 3600 seconds (1 hour) after completion

# ==========================
# Service Account Resources
Expand Down