Add Konnector Charts #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yishaynaPalo
force-pushed
the
ynadav/add-konnector-charts
branch
2 times, most recently
from
03a4a2a to
20694d4
Compare
yishaynaPalo
force-pushed
the
ynadav/add-konnector-charts
branch
from
aa3ed19 to
9bcef03
Compare
adavid-panw
approved these changes
Feb 27, 2025
| RELEASE_NAME: {{.Release.Name | quote }} | ||
| CHART_NAME: {{ .Chart.Name | quote }} | ||
| CHART_VERSION: {{ .Values.image.tag | quote }} | ||
| CONSOLE_LOG_LEVEL: "INFO" |
Contributor
There was a problem hiding this comment.
suggest: move to system values
Collaborator
Author
There was a problem hiding this comment.
Fixed.
I added it to the optional fields since we don't require it, and it has default values in the code.
| {{- include "common.labels" . | nindent 4 }} | ||
| type: Opaque | ||
| stringData: | ||
| token: "--set-by-connector-manager-at-runtime--" |
Contributor
There was a problem hiding this comment.
suggest: consider change this to "<set-by-konnector-runtime>"
yishaynaPalo
force-pushed
the
ynadav/add-konnector-charts
branch
from
cf7e460 to
77779e0
Compare
yishaynaPalo
force-pushed
the
ynadav/add-konnector-charts
branch
from
77779e0 to
3abfc5c
Compare
adavid-panw
approved these changes
Feb 27, 2025
Contributor
adavid-panw
left a comment
adavid-panw
left a comment
There was a problem hiding this comment.
Lookin' good! you rock!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.