Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(post): fixed the profile picture feature for users liking and commenting on post #2355

Conversation

Abhisheksainii
Copy link

What kind of change does this PR introduce?

bugfix - Profile Images of users who have liked and commented is not visible.

Issue Number: #2279

Fixes #2279

  1. Profile images of users liking and commenting on the post is visible now.

Did you add tests for your changes?

No, tests for services and models were already there.

Snapshots/Videos:

If relevant, did you update the documentation?

Summary

Profile Images of users who have liked and commented on the post is not visible and was causing bad user experience.

Does this PR introduce a breaking change?
No

Other information

Have you read the contributing guide?

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

@palisadoes palisadoes changed the title fix(post): fixed the profile picture issue for users liking and commenting on post fix(post): fixed the profile picture feature for users liking and commenting on post Jan 26, 2024
@Cioppolo14
Copy link

@Abhisheksainii Please fix the failing tests.

Copy link
Member

@SiddheshKukade SiddheshKukade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do that requested changes.

Comment on lines +197 to 199
CircleAvatar(
backgroundImage: NetworkImage(comment.creator?.image ?? "")),
Expanded(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a fallback image to this as well

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do it, thanks!

@noman2002
Copy link
Member

@Abhisheksainii Any update on this ?

@Cioppolo14
Copy link

@Abhisheksainii Are you working on this?

@Abhisheksainii
Copy link
Author

@Abhisheksainii Are you working on this?

Not right now

@palisadoes
Copy link
Contributor

Closing due to inactivity

@palisadoes palisadoes closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile images missing for 'Liked by' and 'Comment' users.
5 participants