fix: Misplaced Screen Title & Fix Layout Structure #2088

anuragnegi000 · 2024-07-14T17:30:25Z

What kind of change does this PR introduce?
Bugfix

Issue Number:

Fixes #2071

Did you add tests for your changes?
No, test are not required for this change

Snapshots/Videos:
Before:-

After:-

If relevant, did you update the documentation?
No

Summary
Now the child container is not taking any extra space as it was taking before

Does this PR introduce a breaking change?
No

Other information

Have you read the contributing guide?
Yes

Summary by CodeRabbit

New Features
- Added ProfileDropdown component to the Events, People, and Posts screens, enhancing user navigation and profile management.
Style
- Updated padding values for the main containers in the People and Events screens to improve layout consistency.
Refactor
- Applied consistent layout adjustments for header elements across multiple screens, wrapping h1 elements with enhanced styling.

coderabbitai · 2024-07-14T17:30:33Z

Walkthrough

The recent changes enhance the user interface across multiple screens by integrating a ProfileDropdown component, improving accessibility and user experience. Additionally, CSS adjustments have optimized styling consistency, focusing on padding modifications and the removal of unused classes.

Changes

Files	Change Summary
`src/screens/UserPortal/Events/Events.module.css`	Removed `.colorLight` class and adjusted padding for `.mainContainer`.
`src/screens/UserPortal/Events/Events.tsx`	Added `ProfileDropdown` import and wrapped `<h1>Events</h1>` in a styled `div` with the dropdown.
`src/screens/UserPortal/People/People.module.css`	Reduced `.mainContainer` padding from `40px` to `1rem` and removed `.colorLight` class.
`src/screens/UserPortal/People/People.tsx`	Added `ProfileDropdown` component next to `<h1>`.
`src/screens/UserPortal/Posts/Posts.module.css`	Removed `.colorLight` class; `.mainContainer` padding was not modified.
`src/screens/UserPortal/Posts/Posts.tsx`	Added `ProfileDropdown` import and rendered it alongside `<h1>`.

Assessment against linked issues

Objective	Addressed	Explanation
Screen titles should be moved to parent outlet container (#[2071])	❌	Changes do not address title placement in parent container.

Poem

In code we find our paths align,
With dropdowns added, oh so fine,
Padding shrinks, the styles refine,
The UI now does brightly shine.

🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

github-actions · 2024-07-14T17:30:49Z

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

The overall code coverage drops below the target threshold of the repository
Any file in the pull request has code coverage levels below the repository threshold
Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

comments in this PR or
our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

arbitrators of future discussions with other contributors about the validity of your changes
point of contact for evaluating the validity of your work
person who verifies matching issues by others that should be closed.
person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

PRs with issues not assigned to you will be closed by the reviewer
Fix the first comment in the PR so that each issue listed automatically closes

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
Read the CONTRIBUTING.md file make

github-actions

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 836b534 and 2639155.

Files selected for processing (7)

src/screens/UserPortal/Events/Events.module.css (1 hunks)
src/screens/UserPortal/Events/Events.tsx (2 hunks)
src/screens/UserPortal/People/People.module.css (1 hunks)
src/screens/UserPortal/People/People.tsx (2 hunks)
src/screens/UserPortal/Posts/Posts.module.css (1 hunks)
src/screens/UserPortal/Posts/Posts.tsx (2 hunks)
src/screens/UserPortal/UserScreen/UserScreen.tsx (2 hunks)

Files skipped from review due to trivial changes (4)

src/screens/UserPortal/Events/Events.module.css
src/screens/UserPortal/People/People.module.css
src/screens/UserPortal/Posts/Posts.module.css
src/screens/UserPortal/UserScreen/UserScreen.tsx

Additional comments not posted (6)

src/screens/UserPortal/People/People.tsx (2)

15-15: Import statement added for ProfileDropdown.

This import statement is necessary for the newly added ProfileDropdown component.

128-131: Added ProfileDropdown component next to the h1 element.

The ProfileDropdown component is added for better user profile management and consistency across the UI. The layout structure ensures alignment and spacing are maintained.

src/screens/UserPortal/Posts/Posts.tsx (2)

27-27: Import statement added for ProfileDropdown.

This import statement is necessary for the newly added ProfileDropdown component.

286-289: Added ProfileDropdown component next to the h1 element.

The ProfileDropdown component is added for better user profile management and consistency across the UI. The layout structure ensures alignment and spacing are maintained.

src/screens/UserPortal/Events/Events.tsx (2)

23-23: Import statement added for ProfileDropdown.

This import statement is necessary for the newly added ProfileDropdown component.

163-166: Added ProfileDropdown component next to the h1 element.

The ProfileDropdown component is added for better user profile management and consistency across the UI. The layout structure ensures alignment and spacing are maintained.

anuragnegi000 · 2024-07-16T19:12:04Z

@palisadoes Please do let me know if this PR requires any changes

…awa-admin into develop

src/screens/UserPortal/Events/Events.module.css

varshith257 · 2024-07-16T19:22:22Z

@anuragnegi000 Run prettier to fix format issues

anuragnegi000 · 2024-07-16T19:24:58Z

@varshith257 prettier?

changes in background color Co-authored-by: Vamshi Maskuri <[email protected]>

anuragnegi000

Done!

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2639155 and 63e7065.

Files selected for processing (1)

src/screens/UserPortal/Events/Events.module.css (1 hunks)

Files skipped from review as they are similar to previous changes (1)

src/screens/UserPortal/Events/Events.module.css

varshith257 · 2024-07-16T19:28:41Z

@varshith257 prettier?

npm run format:fix

src/screens/UserPortal/UserScreen/UserScreen.tsx

varshith257 · 2024-07-16T19:33:27Z

Done!

It could be good to remove commented code from all pages that made changes in this PR

anuragnegi000 · 2024-07-16T19:34:26Z

Done!

It could be good to remove commented code from all pages that made changes in this PR

sure

varshith257

LGTM with fixing review comment and format issues

coderabbitai

Actionable comments posted: 1

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 63e7065 and ee2628f.

Files selected for processing (3)

src/screens/UserPortal/Events/Events.module.css (1 hunks)
src/screens/UserPortal/Posts/Posts.module.css (1 hunks)
src/screens/UserPortal/UserScreen/UserScreen.tsx (2 hunks)

Files skipped from review as they are similar to previous changes (2)

src/screens/UserPortal/Posts/Posts.module.css
src/screens/UserPortal/UserScreen/UserScreen.tsx

Additional context used

Biome

src/screens/UserPortal/Events/Events.module.css

[error] 17-17: Expected a compound selector but instead found '='.

Expected a compound selector here.

(parse)

[error] 17-17: expected , but instead found .

Remove .

(parse)

[error] 18-19: Expected a qualified rule, or an at rule but instead found '>>>>>>>63e706517'.

Expected a qualified rule, or an at rule here.

(parse)

src/screens/UserPortal/Events/Events.module.css

anuragnegi000 · 2024-07-16T19:53:04Z

@varshith257 please do let me know if this PR requires any other changes?

varshith257 · 2024-07-16T19:54:33Z

@varshith257 prettier?
npm run format:fix

Can you do this to fix format issues?

anuragnegi000 · 2024-07-16T20:00:12Z

@varshith257 it's still failing

varshith257

LGTM

The test is failing due to PR is develop -> develop branch. We can safely can give exemption for this time

varshith257 · 2024-07-16T20:04:15Z

@anuragnegi000 Make sure from next time to create a new branch for a PR :)

anuragnegi000 · 2024-07-16T20:07:02Z

@anuragnegi000 Maje sure from next time to create a new branch for a PR :)
sure, i'll create new branch from next time, Thank you so much for helping me

palisadoes

Please fix the linting errors

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ee2628f and c206334.

Files selected for processing (3)

src/screens/UserPortal/Events/Events.module.css (1 hunks)
src/screens/UserPortal/People/People.module.css (1 hunks)
src/screens/UserPortal/Posts/Posts.module.css (2 hunks)

Files skipped from review as they are similar to previous changes (3)

src/screens/UserPortal/Events/Events.module.css
src/screens/UserPortal/People/People.module.css
src/screens/UserPortal/Posts/Posts.module.css

anuragnegi000

Code is linted properly

anuragnegi000 · 2024-07-23T17:33:06Z

@palisadoes please re-check as the code is already linted

palisadoes

Please explain the decision on the CSS file update

src/screens/UserPortal/Posts/Posts.module.css

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c206334 and 858eafa.

Files selected for processing (3)

src/screens/UserPortal/Events/Events.module.css (1 hunks)
src/screens/UserPortal/People/People.module.css (1 hunks)
src/screens/UserPortal/Posts/Posts.module.css (2 hunks)

Files skipped from review as they are similar to previous changes (3)

src/screens/UserPortal/Events/Events.module.css
src/screens/UserPortal/People/People.module.css
src/screens/UserPortal/Posts/Posts.module.css

palisadoes · 2024-07-26T19:27:28Z

Please fix the failing tests.

palisadoes · 2024-07-26T19:38:01Z

You'll need to reopen this PR using a different name for the local branch. That'll make it easier for the reviewers to test your changes.

I'll have to close this. This is a welcome change and should be implemented.

anuragnegi000 · 2024-07-26T19:38:49Z

I haven't changed any files among them so why, i'm getting these error?

palisadoes · 2024-07-26T19:46:13Z

Please ask the slack channel. Usually these errors occur when you bypass our husky checks or you haven't merged with the latest upstream code

fix:Misplaced Screen Title & Fix Layout Structure #2071

2639155

github-actions bot reviewed Jul 14, 2024

View reviewed changes

coderabbitai bot reviewed Jul 14, 2024

View reviewed changes

coderabbitai bot previously approved these changes Jul 14, 2024

View reviewed changes

anuragnegi000 and others added 2 commits July 17, 2024 00:42

Merge branch 'develop' of https://github.com/PalisadoesFoundation/tal…

17b22f2

…awa-admin into develop

Merge branch 'develop' into develop

b345f78

varshith257 requested changes Jul 16, 2024

View reviewed changes

src/screens/UserPortal/Events/Events.module.css Outdated Show resolved Hide resolved

Apply suggestions from code review

63e7065

changes in background color Co-authored-by: Vamshi Maskuri <[email protected]>

anuragnegi000 dismissed coderabbitai’s stale review via 63e7065 July 16, 2024 19:27

coderabbitai bot previously approved these changes Jul 16, 2024

View reviewed changes

anuragnegi000 commented Jul 16, 2024

View reviewed changes

coderabbitai bot reviewed Jul 16, 2024

View reviewed changes

varshith257 reviewed Jul 16, 2024

View reviewed changes

src/screens/UserPortal/UserScreen/UserScreen.tsx Show resolved Hide resolved

anuragnegi000 added 2 commits July 17, 2024 01:06

removed all the commented lines

9509daf

removed all comments

ee2628f

anuragnegi000 dismissed coderabbitai’s stale review via ee2628f July 16, 2024 19:39

varshith257 previously approved these changes Jul 16, 2024

View reviewed changes

coderabbitai bot requested changes Jul 16, 2024

View reviewed changes

src/screens/UserPortal/Events/Events.module.css Outdated Show resolved Hide resolved

coderabbitai bot previously approved these changes Jul 16, 2024

View reviewed changes

removed the conflict

a298bf8

anuragnegi000 dismissed stale reviews from coderabbitai and varshith257 via a298bf8 July 16, 2024 19:45

coderabbitai bot previously approved these changes Jul 16, 2024

View reviewed changes

removed all comments

77b8750

anuragnegi000 dismissed coderabbitai’s stale review via 77b8750 July 16, 2024 19:50

varshith257 changed the title ~~fix:Misplaced Screen Title & Fix Layout Structure #2071~~ fix: Misplaced Screen Title & Fix Layout Structure Jul 16, 2024

final changes

527f9bb

varshith257 previously approved these changes Jul 16, 2024

View reviewed changes

palisadoes approved these changes Jul 23, 2024

View reviewed changes

palisadoes requested changes Jul 23, 2024

View reviewed changes

Merge branch 'develop' into develop

c206334

coderabbitai bot reviewed Jul 23, 2024

View reviewed changes

coderabbitai bot previously approved these changes Jul 23, 2024

View reviewed changes

anuragnegi000 commented Jul 23, 2024

View reviewed changes

palisadoes requested changes Jul 25, 2024

View reviewed changes

src/screens/UserPortal/Posts/Posts.module.css Outdated Show resolved Hide resolved

changes from px to rem

858eafa

anuragnegi000 dismissed stale reviews from coderabbitai and varshith257 via 858eafa July 26, 2024 10:04

coderabbitai bot reviewed Jul 26, 2024

View reviewed changes

coderabbitai bot approved these changes Jul 26, 2024

View reviewed changes

Merge branch 'develop' into develop

5444409

palisadoes closed this Jul 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Misplaced Screen Title & Fix Layout Structure #2088

fix: Misplaced Screen Title & Fix Layout Structure #2088

anuragnegi000 commented Jul 14, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 14, 2024 •

edited

Loading

github-actions bot commented Jul 14, 2024

github-actions bot left a comment

coderabbitai bot left a comment

anuragnegi000 commented Jul 16, 2024

varshith257 commented Jul 16, 2024

anuragnegi000 commented Jul 16, 2024

anuragnegi000 left a comment

coderabbitai bot left a comment

varshith257 commented Jul 16, 2024

varshith257 commented Jul 16, 2024

anuragnegi000 commented Jul 16, 2024

varshith257 left a comment

coderabbitai bot left a comment

anuragnegi000 commented Jul 16, 2024

varshith257 commented Jul 16, 2024

anuragnegi000 commented Jul 16, 2024

varshith257 left a comment •

edited

Loading

varshith257 commented Jul 16, 2024 •

edited

Loading

anuragnegi000 commented Jul 16, 2024

palisadoes left a comment

coderabbitai bot left a comment

anuragnegi000 left a comment

anuragnegi000 commented Jul 23, 2024

palisadoes left a comment

coderabbitai bot left a comment

palisadoes commented Jul 26, 2024

palisadoes commented Jul 26, 2024

anuragnegi000 commented Jul 26, 2024

palisadoes commented Jul 26, 2024

fix: Misplaced Screen Title & Fix Layout Structure #2088

fix: Misplaced Screen Title & Fix Layout Structure #2088

Conversation

anuragnegi000 commented Jul 14, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Jul 14, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Poem

github-actions bot commented Jul 14, 2024

Our Pull Request Approval Process

Testing Your Code

Reviewers

Reviewing Your Code

CONTRIBUTING.md

Other

github-actions bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

anuragnegi000 commented Jul 16, 2024

varshith257 commented Jul 16, 2024

anuragnegi000 commented Jul 16, 2024

anuragnegi000 left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

varshith257 commented Jul 16, 2024

varshith257 commented Jul 16, 2024

anuragnegi000 commented Jul 16, 2024

varshith257 left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

anuragnegi000 commented Jul 16, 2024

varshith257 commented Jul 16, 2024

anuragnegi000 commented Jul 16, 2024

varshith257 left a comment • edited Loading

Choose a reason for hiding this comment

varshith257 commented Jul 16, 2024 • edited Loading

anuragnegi000 commented Jul 16, 2024

palisadoes left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

anuragnegi000 left a comment

Choose a reason for hiding this comment

anuragnegi000 commented Jul 23, 2024

palisadoes left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

palisadoes commented Jul 26, 2024

palisadoes commented Jul 26, 2024

anuragnegi000 commented Jul 26, 2024

palisadoes commented Jul 26, 2024

anuragnegi000 commented Jul 14, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 14, 2024 •

edited

Loading

varshith257 left a comment •

edited

Loading

varshith257 commented Jul 16, 2024 •

edited

Loading