Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report - Organizations Page placeholder, rows option fix #2117

Closed
mahak-juriani opened this issue Jul 24, 2024 · 17 comments
Closed

Bug Report - Organizations Page placeholder, rows option fix #2117

mahak-juriani opened this issue Jul 24, 2024 · 17 comments
Assignees
Labels
bug Something isn't working

Comments

@mahak-juriani
Copy link

Describe the bug
Under My Organizations - for pagination options - rows per page has an option of -1,
search placeholder shows 'Search users' instead of 'Search organizations'

To Reproduce
Steps to reproduce the behavior:

  1. Login as User
  2. Go to My Organizations
  3. Search bar placeholder shows 'Search users' instead of 'Search organizations'
  4. One more, at the bottom rows per page dropdown has an option with -1 value

Expected behavior
Placeholder should be Search organizations.
-1 should not be an option for rows per page

Screenshots
Talawa - select organization placeholder

rows per page -1
@mahak-juriani mahak-juriani added the bug Something isn't working label Jul 24, 2024
@mahak-juriani
Copy link
Author

Please assign me this issue @varshith257 @pranshugupta54 as good first issue
Thank you

@palisadoes
Copy link
Contributor

palisadoes commented Jul 25, 2024

  1. Please write tests as part of the PR.
  2. We don't want this error to be repeated.
  3. Ensure that you test all the drop down values and placeholder texts

Copy link

github-actions bot commented Aug 5, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Aug 5, 2024
@Cioppolo14
Copy link

@mahak-juriani Are you working on this?

@github-actions github-actions bot removed the no-issue-activity No issue activity label Aug 7, 2024
@Ramneet04
Copy link

@Cioppolo14 hey can I work on this, I'll make sure to do it as early it is possible
Thanks..

@Ramneet04
Copy link

Ramneet04 commented Aug 13, 2024

Hey @palisadoes I have fixed the Bug over here and it's working fine. But how can run test to check it?? Here's the screenshots.

RowsPerPage
SearchOrg

@palisadoes
Copy link
Contributor

Please ask the #talawa-admin slack channel

@Ramneet04
Copy link

Alright

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Aug 24, 2024
@Ramneet04
Copy link

Will raise pr in a day or 2 days.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Aug 25, 2024
@palisadoes
Copy link
Contributor

Unassigning. inactivity.

@AnshulKahar2729
Copy link

@palisadoes Would like to work on this

@palisadoes
Copy link
Contributor

@AnshulKahar2729

Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Sep 10, 2024
@prayanshchh
Copy link

can i work on this issue?

@github-actions github-actions bot removed the no-issue-activity No issue activity label Sep 16, 2024
@prayanshchh
Copy link

I have fixed the bug, I just need to write tests, can you assign the issue?

@prayanshchh
Copy link

prayanshchh commented Sep 18, 2024

Hi, there is not test present for PaginationList, shall I create a file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants