Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add modal closebutton and unclosable modal #13

Merged
merged 5 commits into from
May 8, 2024
Merged

add modal closebutton and unclosable modal #13

merged 5 commits into from
May 8, 2024

Conversation

HSallinen
Copy link
Member

No description provided.

@HSallinen HSallinen self-assigned this Jan 22, 2024
@HSallinen HSallinen added enhancement New feature or request accessibility This is related to accessibility functionality This is related to the pages functionality labels Jan 22, 2024
@HSallinen HSallinen marked this pull request as draft January 29, 2024 17:18
@HSallinen HSallinen linked an issue Jan 29, 2024 that may be closed by this pull request
Modal has no close button #3
Closed
dkristia
dkristia reviewed Jan 31, 2024
View reviewed changes
@HSallinen HSallinen changed the title add close button and onclosefunction to modal add modal closebutton and unclousable modal Apr 24, 2024
@HSallinen HSallinen marked this pull request as ready for review April 24, 2024 10:19
@HSallinen HSallinen changed the title add modal closebutton and unclousable modal add modal closebutton and unclosable modal May 6, 2024
dkristia
dkristia approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@dkristia dkristia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thumbs up emoji

@dkristia dkristia merged commit 8e7b1f3 into main May 8, 2024
@dkristia dkristia deleted the modal_close_button branch May 8, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joksupoksu joksupoksu joksupoksu approved these changes

@dkristia dkristia dkristia approved these changes

Assignees

@HSallinen HSallinen

Labels
accessibility This is related to accessibility enhancement New feature or request functionality This is related to the pages functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modal has no close button
3 participants
@HSallinen @joksupoksu @dkristia