Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal has no close button #3

Closed
HSallinen opened this issue Jan 8, 2024 · 0 comments · Fixed by #13
Closed

Modal has no close button #3

HSallinen opened this issue Jan 8, 2024 · 0 comments · Fixed by #13
Assignees
@HSallinen
Labels
accessibility This is related to accessibility enhancement New feature or request to do Should be done soon

Comments

@HSallinen
Copy link
Member

HSallinen commented Jan 8, 2024 •
edited
Loading

modal(popup) needs to have a close button for accessibility
@HSallinen HSallinen added enhancement New feature or request accessibility This is related to accessibility to do Should be done soon labels Jan 22, 2024
@HSallinen HSallinen self-assigned this Jan 22, 2024
@HSallinen HSallinen added in progress Issue is being worked on awaiting review Issue is fixed but not yet merged into main and removed to do Should be done soon in progress Issue is being worked on labels Jan 22, 2024
@HSallinen HSallinen linked a pull request Jan 29, 2024 that will close this issue
add modal closebutton and unclosable modal #13
Merged
@usvakangas usvakangas added to do Should be done soon and removed awaiting review Issue is fixed but not yet merged into main labels Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HSallinen HSallinen

Labels
accessibility This is related to accessibility enhancement New feature or request to do Should be done soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add modal closebutton and unclosable modal Paivola-Student-Innovation-Lab/DailyCrypt
2 participants
@usvakangas @HSallinen