fix chap04

CHAP04/archive/main.tf

@@ -13,3 +13,8 @@ data "archive_file" "backup" {
   source_file = "../mytextfile.txt"
   output_path = "${path.module}/archives/backup.zip"
 }
+
+
+output "archive" {
+  value = data.archive_file.backup.id
+}

CHAP04/data/main.tf

@@ -11,12 +11,6 @@ provider "azurerm" {
   features {}
 }
 
-locals {
-  common_app_settings = {
-    "INSTRUMENTATIONKEY" = azurerm_application_insights.appinsight-app.instrumentation_key
-  }
-}
-
 resource "azurerm_resource_group" "rg-app" {
   name     = "${var.resource_group_name}-${var.environment}"
   location = var.location

CHAP04/data/variables.tf

@@ -1,32 +1,28 @@
 variable "resource_group_name" {
   description = "Resource group name"
+  type        = string
 }
 
 variable "location" {
   description = "Location of Azure reource"
   default     = "westeurope"
+  type        = string
 }
 
-variable "service_plan_name" {
-  description = "Service plan name"
-}
 
 variable "app_name" {
   description = "Name of application"
   default     = "MyApp"
+  type        = string
 }
 
 variable "environment" {
   description = "Environment Name"
-}
-
-
-variable "custom_app_settings" {
-  description = "Custom App settings"
-  default     = {}
+  type        = string
 }
 
 variable "createdby" {
   description = "name of the triggers user"
   default     = "NA"
+  type        = string
 }

CHAP04/external/main.tf

@@ -4,14 +4,17 @@ provider "azurerm" {
 
 variable "application_name" {
   description = "The name of application"
+  type        = string
 }
 
 variable "environment_name" {
   description = "The name of environment"
+  type        = string
 }
 
 variable "country_code" {
   description = "The country code (FR-US-...)"
+  type        = string
 }
 
 locals {
@@ -28,7 +31,7 @@ data "external" "getlocation" {
   program = ["pwsh", "./GetLocation.ps1"]
 
   query = {
-    environment = "${var.environment_name}"
+    environment = var.environment_name
   }
 }