Explicit modality set when "New..." is selected #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The popup that happens for entering a category when "New..." is selected is currently NOT modal, despite line 14 stating "modal=True" I tested it on Ubuntu, Windows 10 and macOS (Big Sur). All of them showed the category dialog and you could put in the background and return to the main calendar window, which wouldn't be the correct behavior. Adding this line before the show command: self.setWindowModality(qtc.Qt.ApplicationModal) Makes it so the Category dialog is modal. Tested on Windows, Ubuntu, and macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The popup that happens for entering a category when "New..." is selected is currently NOT modal, despite line 14 stating "modal=True"
I tested it on Ubuntu, Windows 10 and macOS (Big Sur). All of them showed the category dialog and you could put it in the background and return to the main calendar window, which wouldn't be the correct behavior.
Adding this line before the show command:
self.setWindowModality(qtc.Qt.ApplicationModal)
Makes it so the Category dialog is modal.
Tested on Windows, Ubuntu, and macOS.
I'm just learning PyQt, so perhaps there's a better way, but this way does work.