Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date parsing when used in a title #16

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Fix date parsing when used in a title #16

merged 2 commits into from
Feb 12, 2025

Conversation

thhomas
Copy link
Collaborator

@thhomas thhomas commented Jan 14, 2025

When using $TIME_PERIOD in a text expression (title or subtitle) it should render the min and max dates for the observations. Used to be resolved by first and last item in the dimension values array but turns out that the array is not always sorted.

Should fix #14

@thhomas thhomas marked this pull request as ready for review January 14, 2025 16:55
@thhomas thhomas requested a review from stanozr January 14, 2025 16:55
Never used, breaks the build process
Copy link
Collaborator

@stanozr stanozr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope this is still relevant.
@thhomas up to you to merge.

@thhomas thhomas merged commit c3c2e69 into main Feb 12, 2025
@thhomas thhomas deleted the fixDateParsing branch February 12, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix parsing of dates in text expression
2 participants