Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

FFmpeg: adapt to ffmpeg7 for dumping. #248

Merged
merged 3 commits into from
Oct 12, 2024
Merged

Conversation

kongfl888
Copy link
Contributor

After ffmpeg 5.1, it is deprecated, and has been completely removed in ffmpeg 7.

Our current project is using 6.0 headers, modifying it will not have any side effects.

For msys2,

the version of ffmpeg has been updated to 7.0.2.

We may need to update the library headers.
PabloMK7/ext-library-headers#1

@PabloMK7
Copy link
Owner

Hello, mind briefly explaining why this is needed?

@kongfl888
Copy link
Contributor Author

kongfl888 commented Aug 31, 2024

Recording a video requires ffmpeg. And the released version of msys2 is already ffmpeg7.0.2. For example: citra-windows-msys2-20240821-5115f64

@PabloMK7
Copy link
Owner

Yes I know, but are there any known benefits of bumping the version? Or is it just to keep everything updated?

@kongfl888
Copy link
Contributor Author

kongfl888 commented Aug 31, 2024

Yes I know, but are there any known benefits of bumping the version? Or is it just to keep everything updated?

Our released version is already packaged with ffmpeg7.
The update will not have any functional impact.

(citra-windows-msys2-20240821-5115f64)

This is a compilation update. If you are using ffmpeg7 headers, the compilation will encounter errors.

@kongfl888
Copy link
Contributor Author

I opened an issue
#249

@PabloMK7
Copy link
Owner

Can you update the sumbodule as well to use commit: PabloMK7/ext-library-headers@9d99e11

@rtiangha
Copy link
Contributor

rtiangha commented Oct 6, 2024

FYI, msys2 switched to ffmpeg n7.1 so this may need to be done again; subbing in 7.1 headers makes Citra not compile.

After ffmpeg 5.1, it is deprecated, and has been completely removed in ffmpeg 7.

Our current project is using 6.0 headers, modifying it will not have any side effects.

Since lavu 57.24.100(ffmpeg 5.1)
But keeping support for older versions.
@kongfl888 kongfl888 changed the title FFmpeg: update layout api for ffmpeg 6.x and ffmpeg 7. FFmpeg: adapt to ffmpeg7 for dumping. Oct 7, 2024
@kongfl888
Copy link
Contributor Author

Adapt to ffmpeg 7.1 (and older versions), and rebase.

@kongfl888
Copy link
Contributor Author

Both the commits from August and October are compatibility fixes,
and whether you update ext-library-headers or not will not affect the current state.
But when you use new header files outside the project, such as setting USE_SYSTEM_FFMPEG_HEADERS to use local system header files, these fixes will take effect.

Have a good day...

@PabloMK7
Copy link
Owner

Mind bumping the submodule again? Will merge after.

@rtiangha
Copy link
Contributor

rtiangha commented Oct 11, 2024

Edit: Ah never mind; I'm like 2 hours behind the latest info, lol.

@kongfl888
Copy link
Contributor Author

Mind bumping the submodule again? Will merge after.

done. thank you.

@PabloMK7 PabloMK7 merged commit cdce026 into PabloMK7:master Oct 12, 2024
12 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants