Simplifying feature api. Breaking changes. PHP >= 8.0

.travis.yml

@@ -1,7 +1,7 @@
 language: php
 
 php:
-  - '7.2'
+  - '8.0'
   - nightly
 
-script: composer install --no-interaction && composer phpstan && composer phpunit
+script: composer install --no-interaction && composer test

composer.json

@@ -22,15 +22,16 @@
         "toggle"
     ],
     "require": {
-        "php": ">=7.2"
+        "php": ">=8.0"
     },
     "require-dev": {
         "phpunit/phpunit": "*",
-        "phpstan/phpstan": "*"
+        "phpstan/phpstan": "*",
+        "vimeo/psalm": "*",
+        "squizlabs/php_codesniffer": "*"
     },
     "scripts": {
-        "phpstan": "./vendor/bin/phpstan analyse --level=max --debug -vvv src/ tests/",
-        "phpunit": "./vendor/bin/phpunit --stop-on-failure --fail-on-warning --fail-on-risky -v --debug --coverage-text --whitelist src/ tests/"
+        "test": "./vendor/bin/phpcbf --standard=PSR12 src/ tests/ && ./vendor/bin/phpstan analyse --level=max --debug -vvv src/ tests/ && ./vendor/bin/psalm && php -d xdebug.mode=coverage ./vendor/bin/phpunit --stop-on-failure --fail-on-warning --fail-on-risky -v --debug --coverage-text --whitelist src/ tests/ && ./vendor/bin/phpcs --standard=PSR12 src/ tests/"
     },
     "autoload": {
         "psr-4": {

psalm.xml

@@ -0,0 +1,29 @@
+<?xml version="1.0"?>
+<psalm
+    errorLevel="1"
+    resolveFromConfigFile="true"
+    totallyTyped="true"
+    reportMixedIssues="true"
+    strictBinaryOperands="true"
+    ignoreInternalFunctionFalseReturn="false"
+    ignoreInternalFunctionNullReturn="false"
+    findUnusedVariablesAndParams="true"
+    findUnusedCode="true"
+    ensureArrayStringOffsetsExist="true"
+    runTaintAnalysis="true"
+    reportInfo="true"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xmlns="https://getpsalm.org/schema/config"
+    xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
+>
+    <projectFiles>
+        <directory name="src" />
+        <ignoreFiles>
+            <directory name="vendor" />
+        </ignoreFiles>
+    </projectFiles>
+
+    <issueHandlers>
+        <LessSpecificReturnType errorLevel="info" />
+    </issueHandlers>
+</psalm>

src/Bucketing/Calculator/Id.php → src/Bucketing/Id.php

@@ -2,23 +2,27 @@
 
 declare(strict_types=1);
 
-namespace PabloJoan\Feature\Bucketing\Calculator;
+namespace PabloJoan\Feature\Bucketing;
 
-class Id
+final class Id implements Type
 {
     /**
      * Map a hex value to the half-open interval between 0 and 1 while
      * preserving uniformity of the input distribution.
      */
-    function number (string $idToHash) : float
+    public function randomIshNumber(string $idToHash = ''): float
     {
         $hash = hash('haval192,3', $idToHash);
+
+        $maxIterations = strlen($hash) - 1;
+        $maxValueOfX = 2 ** $maxIterations;
+
         $x = 0;
-        for ($i = 0; $i < 47; ++$i) {
+        for ($i = 0; $i < $maxIterations; ++$i) {
             $x = ($x * 2) + (hexdec($hash[$i]) < 8 ? 0 : 1);
         }
 
-        $x = $x / 140737488355328; // ( 2 ** 47 ) is the max value of $x
+        $x = $x / $maxValueOfX;
 
         return $x * 100;
     }

src/Bucketing/Random.php

@@ -4,18 +4,11 @@
 
 namespace PabloJoan\Feature\Bucketing;
 
-use PabloJoan\Feature\Value\User;
-use PabloJoan\Feature\Bucketing\Calculator\Random as Calculator;
-
-class Random implements Type
+final class Random implements Type
 {
-    function id (User $user) : string
-    {
-        return $user->uaid() ?: 'no uaid';
-    }
-
-    function number (string $idToHash) : float
+    public function randomIshNumber(string $idToHash = ''): float
     {
-        return (new Calculator)->number();
+        $x = random_int(0, PHP_INT_MAX - 1) / PHP_INT_MAX;
+        return $x * 100;
     }
 }

src/Bucketing/Type.php

@@ -4,15 +4,11 @@
 
 namespace PabloJoan\Feature\Bucketing;
 
-use PabloJoan\Feature\Value\User;
-
 interface Type
 {
-    function id (User $user) : string;
-
     /**
      * A random-ish number between 0 and 100 based on the feature name and $id
      * unless we are bucketing completely at random
      */
-    function number (string $idToHash) : float;
+    public function randomIshNumber(string $idToHash = ''): float;
 }

src/Configurations/Collection.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace PabloJoan\Feature\Configurations;
+
+final class Collection
+{
+    /**
+     * @var Config[]
+     */
+    private array $configurations;
+
+    /**
+     * @param array<string|int, array{enabled: int|array, bucketing?: string}> $configurations
+     */
+    public function __construct(array $configurations)
+    {
+        foreach ($configurations as $featureName => $config) {
+            $this->configurations[(string)$featureName] = new Config(config: $config);
+        }
+    }
+
+    public function get(string $featureName): Config
+    {
+        return $this->configurations[$featureName];
+    }
+}