Enable/disable annotation editing Deo #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutumbakato
commented
May 30, 2025
There was a problem hiding this comment.
Generated by pigeon.
mutumbakato
commented
May 30, 2025
There was a problem hiding this comment.
Generated by pigeon.
mutumbakato
commented
May 30, 2025
There was a problem hiding this comment.
Generated by pigeon.
mutumbakato
commented
May 30, 2025
| Future<double> getZoomScale(int pageIndex) { | ||
| return pspdfkitInstance.getZoomScale(pageIndex); | ||
| } | ||
|
|
There was a problem hiding this comment.
Pigeon method definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This pull request introduces support for enabling and disabling annotation editing in the Nutrient Flutter plugin. The changes span Android, iOS, and Dart implementations, providing a unified API for managing annotation editing capabilities. Additionally, an example showcasing this functionality has been added to the project.
Feature Implementation: Annotation Editing
Android Changes:
enableAnnotationEditinginPspdfkitViewImplto updatePdfActivityConfigurationdynamically for enabling or disabling annotation editing.PspdfkitWidgetControllerApiinterface and its message handler to include theenableAnnotationEditingmethod. [1] [2]iOS Changes:
enableAnnotationEditingmethod inPspdfkitPlatformViewImplto modifyeditableAnnotationTypesin the PDF view controller configuration based on the provided parameters.PspdfkitWidgetControllerApiprotocol and its message handler for the new method. [1] [2]Dart API Updates:
enableAnnotationEditingmethod inPspdfkitWidgetControllerand its implementations (PspdfkitWidgetControllerImpl,PspdfkitWidgetControllerNative, andPspdfkitWidgetControllerWeb). [1] [2] [3] [4]Example Addition:
DisableAnnotationEditingExampleto demonstrate the usage of theenableAnnotationEditingmethod, allowing users to toggle annotation editing via a button.Miscellaneous Updates:
These changes collectively enhance the PSPDFKit Flutter plugin by providing a flexible API for annotation editing, along with a practical example to help you understand and utilize the feature effectively. We will add this feature to our roadmap for future implementation.