fix: prevent copying a folder into itself or its subfolders to match … #1501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
![pkuhpc-review-bot[bot]](https://avatars.githubusercontent.com/in/631823?s=60&v=4){kind=small}
| const toPath = join(path, x.name); | ||
|
|
||
| // 阻止复制到自身或子目录 | ||
| if (toPath === fromPath || toPath.startsWith(fromPath + "/")) { |
There was a problem hiding this comment.
这里的路径比较逻辑可以更精确一些，防止路径比较时的误判。建议使用path.resolve()规范化路径后再进行比较
Suggested change
| if (toPath === fromPath || toPath.startsWith(fromPath + "/")) { | |
| if (path.resolve(toPath) === path.resolve(fromPath) || path.resolve(toPath).startsWith(path.resolve(fromPath) + path.sep)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
本次代码变更有以下几点：