Skip to content

Fixed #713 #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fixed #713 #715

wants to merge 3 commits into from

Conversation

Geolim4
Copy link
Member

@Geolim4 Geolim4 commented Dec 3, 2019

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Phpfastcache?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing code/behavior)
  • Deprecated third party dependency update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation/Typo/Resource update that does not involve any code modification

Agreement

I have read the CONTRIBUTING and CODING GUIDELINE docs

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@Geolim4
Copy link
Member Author

Geolim4 commented Dec 3, 2019

WARNING: HIGHLY BREAKING CHANGE PR: DO NOT MERGE
See why: #713 (comment)

@PHPSocialNetwork PHPSocialNetwork locked as resolved and limited conversation to collaborators Dec 3, 2019
@Geolim4
Copy link
Member Author

Geolim4 commented Dec 3, 2019

Massive broken features detected here:
https://travis-ci.org/PHPSocialNetwork/phpfastcache/jobs/620367464#L2381

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants