Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper css inline border #1670 #2728

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

Azamat8405
Copy link
Contributor

@Azamat8405 Azamat8405 commented Jan 23, 2025

Description

Fixes #1670

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
  • I have updated the changelog

Sorry, something went wrong.

Azamat8405 and others added 6 commits November 21, 2024 14:33

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
azamat8405/phpword

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@coveralls
Copy link

coveralls commented Jan 23, 2025

Coverage Status

coverage: 96.807% (+0.04%) from 96.767%
when pulling ae3767f on Azamat8405:properCSSInlineBorder1670
into 6ca8c9f on PHPOffice:master.

Azamat8405 and others added 8 commits January 23, 2025 18:45

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
# Conflicts:
#	docs/changes/1.x/1.4.0.md
Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Azamat8405 Could you add unit tests with differents combinations of styles, please ?

@Progi1984 Progi1984 added the Status: Waiting for feedback Question has been asked, waiting for response from PR author label Feb 12, 2025
OlisaevAG and others added 3 commits February 17, 2025 12:32

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@Azamat8405
Copy link
Contributor Author

@Progi1984, i have issue with getMockForAbstractClass method during PHP Static Analysis.

could you check it please?

Azamat8405 and others added 2 commits February 27, 2025 16:08

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@Azamat8405
Copy link
Contributor Author

@Progi1984 hello!
Could you review current PR again please.

OlisaevAG added 3 commits February 27, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Waiting for feedback Question has been asked, waiting for response from PR author
Development

Successfully merging this pull request may close these issues.

addHtml > proper CSS inline border
3 participants