WIP Do Not Install#2567
Draft
oleibman wants to merge 193 commits intoPHPOffice:masterfrom
Draft
Conversation
All my unimplemented changes. Not intended for install.
Better from a technical standpoint. Pre-processing much simplified. Some post-processing added because loadHTML preserveWhiteSpace=false does not work well. Not-UTF8 html can now be loaded. No need to surround snippets with body tag.
It's debatable, but allow unescaped ampersand and unknown charset.
I made RTF usable some time ago. @rasamassen has recently done a lot of useful work to cover many missing areas. Since who knows when those changes will be merged, I intend to incorporate much of that work. I will do this with several pushes, each based on one or more of those changes. This one is based on PR PHPOffice#2817, PR PHPOffice#2834, and PR PHPOffice#2835.
Try again with a meaningless comment change.
I made RTF usable some time ago. @rasamassen has recently done a lot of useful work to cover many missing areas. Since who knows when those changes will be merged, I intend to incorporate much of that work. I will do this with several pushes, each based on one or more of those changes. This one is based on PR PHPOffice#2838.
Fix PHPOffice#2490. Fix PHPOffice#2188.
Based on PR PHPOffice#2790 by @prog-klk1
Based on PR PHPOffice#2806 by @geo-fret. Fix PHPOffice#2795 (which also requests ico, but geo-fret believes that isn't supported in docx).
Based on PR PHPOffice#2854 by @Tom-Magill.
Implement PR PHPOffice#2858.
They can all be null in addition to bool. This addresses the problem in issue PHPOffice#2118.
Adapted from PR PHPOffice#2862 by @ger82. Corrected some errors (Word2007 should not write 2 `w:u` entries when `underlineColor` is specified, Html needs to be more careful about when to prepend `#`). Added read support for Word2007 and Html. Add RTF Reader support for various underline styles. RTF Reader does not appear to support colors at all; that will have to be the subject of another PR. ODText Reader does not appear to support any styles; that will have to be the subject of at least one far more complicated PR.
Apply colors to Font color, fgColor, and underlineColor.
Apply font names correctly. Also, font size needs to be divided by 2.
Also, langId for Slovenian was wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All my unimplemented changes. Not intended for install.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
Checklist:
composer run-script check --timeout=0and no errors were reported