Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Cloud 2.0 and adapt to upstream changes #33

Merged
merged 3 commits into from
Jun 23, 2024

Conversation

calcastor
Copy link
Contributor

WIP update to Cloud 2.0, depends on PGMDev/PGM#1319

Removes confirmation manager like in the PGM PR, currently untested.

@calcastor calcastor marked this pull request as draft May 19, 2024 02:16
@calcastor calcastor changed the title Update to Cloud v2.0 Update to Cloud 2.0 May 20, 2024
Signed-off-by: BT (calcastor/mame) <[email protected]>
@calcastor calcastor marked this pull request as ready for review May 30, 2024 05:21
Signed-off-by: BT (calcastor/mame) <[email protected]>
@calcastor calcastor changed the title Update to Cloud 2.0 Update to Cloud 2.0 and adapt to upstream changes Jun 23, 2024
@calcastor
Copy link
Contributor Author

This now builds against Java 21 given upstream PGM's dependency on Java 21.

To ensure functionality in modern Minecraft, a future PR should depend on the intersect jar used by PGM. This will require a port to Adventure.

@calcastor calcastor force-pushed the cloud-2.0 branch 3 times, most recently from ca6e980 to d926e59 Compare June 23, 2024 22:29
Signed-off-by: BT (calcastor/mame) <[email protected]>
@Pablete1234 Pablete1234 merged commit d8004a6 into PGMDev:master Jun 23, 2024
2 checks passed
@calcastor calcastor deleted the cloud-2.0 branch June 24, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants