Debugger: Redesign UI based on docking system

[chaoticgd]

Description of Changes

I have redesigned the debugger's UI based on the KDDockWidgets docking system library. Work in progress!

Some issues:

• KDDockWidgets uses exceptions and RTTI (dynamic_cast).
• I made a prototype version using Qt Advanced Docking System which featured a fancy stylesheet. It would be possible to implement such a theme using KDDW too, although the developer recommends against using stylesheets so I think it would be better left for a future PR.

Rationale behind Changes

I feel like the current design has been limiting the kind of improvements I can make to the debugger.

As for the choice of library, there were three to pick from: Qt's own QDockWidget class, Qt Advanced Docking System and KDDockWidgets.

QDockWidget isn't really appropriate since the dock widgets behave more like oversized toolbars surrounding an unmoving central widget rather than a tree of splitters.

I evaluated Qt Advanced Docking System but dropped it due to poor Linux compatibility and extremely poor Wayland compatibility.

KDDockWidgets seems like the overall best pick. Best feature set, best platform compatibility, and it's backed up by KDAB.

Suggested Testing Steps

This is not yet ready for testing.

[TellowKrinkle]

BTW for the final version, you should link to kddockwidgets as a system library and add it to the dependency build scripts instead of including the source here. This should also allow you to not enable rtti/exceptions on the rest of PCSX2.

[chaoticgd]

BTW for the final version, you should link to kddockwidgets as a system library and add it to the dependency build scripts instead of including the source here. This should also allow you to not enable rtti/exceptions on the rest of PCSX2.

This is a good idea.

[chaoticgd]

I've switched to pulling in KDDockWidgets in the build-dependencies scripts, and I agree that regardless it's better, but it doesn't seem to be solving the problem with exceptions/RTTI. Whenever it enters a dynamic_cast in KDDW it just aborts with RTTI disabled. Does anyone have experience with this? Note that while I'm not currently doing this, it may be necessary to inherit from some of the KDDW types to customize some of the docking widgets in the future. If it's not feasible I could just develop a patch.

[TheLastRar]

A google search found this stackoverflow answer,
Based on the above, any PCSX2 classes that inherit from KDDW would lack the RTTI information, but KDDW might expect it as the base classes would have RTTI info.

You are inheriting a KDDW class from within PCSX2 (DebuggerWindow inherits from KDDockWidgets::QtWidgets::MainWindow)
Is KDDW using RTTI functions on this class?

[chaoticgd]

You are inheriting a KDDW class from within PCSX2 (DebuggerWindow inherits from KDDockWidgets::QtWidgets::MainWindow) Is KDDW using RTTI functions on this class?

Ah yes, I forgot about that. It does.

[chaoticgd]

It seems we have two options: Either I develop a patch for KDDockWidgets to remove the uses of dynamic_cast, or we enable RTTI for pcsx2-qt. What would you all prefer I do?