-
Notifications
You must be signed in to change notification settings - Fork 2
Refactor/#134 kakao to naver #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
bbd8072
db318c6
c23e3de
e5b4cc0
1dcc1f4
09b7b44
5f290e6
0323040
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,13 +15,14 @@ import androidx.compose.ui.tooling.preview.Preview | |
| import androidx.compose.ui.unit.dp | ||
| import com.paw.key.R | ||
| import com.paw.key.core.designsystem.theme.PawKeyTheme | ||
| import com.paw.key.core.util.noRippleClickable | ||
| import com.paw.key.core.extension.noRippleClickable | ||
|
|
||
| @Composable | ||
| fun TopBar( | ||
| title: String, | ||
| onBackClick: () -> Unit, | ||
| modifier: Modifier = Modifier, | ||
| onClickTitle : () -> Unit = {}, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 피그마에 컴포넌트가 없어서 잘은 모르겠는데, 선택적으로 콜백 할라고 한건가용
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 아 이거 회원가입 플로우를 건너뛰고 바로 홈으로 이동하기 위해 만든 일종의 이스터에그 입니다 ㅎㅎ 나중에 플로우 확립되면 제거 예정 지금은 테스트용! |
||
| isBackVisible: Boolean = true, | ||
| ) { | ||
| Box( | ||
|
|
@@ -45,6 +46,7 @@ fun TopBar( | |
| style = PawKeyTheme.typography.head18Sb, | ||
| modifier = Modifier | ||
| .align(Alignment.Center) | ||
| .noRippleClickable(onClickTitle) | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| package com.paw.key.core.extension | ||
|
|
||
| import android.location.Location | ||
| import com.naver.maps.geometry.LatLng | ||
|
|
||
| fun Location.toLatLng(): LatLng { | ||
| return LatLng(this.latitude, this.longitude) | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,15 @@ | ||
| package com.paw.key.core.util | ||
|
|
||
| sealed class UiState<out T> { | ||
| data object Empty : UiState<Nothing>() | ||
| sealed interface UiState<out T> { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. util 쪽 코드를 잘 안짜봐서 모르긴한데, class -> interface로 변경한 이유가 있을까요?(순수 궁금)
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 우선 UiState의 역할을 저는 그 자체로 동작을 갖지않고 상태만 구분하기 위한 것이라 생각해서 interface로 의도를 명확히 하고 또 class로 사용 시 class 자체의 기본적으로 상속받는 equals, hashcode, toString이런 것들을 자동 상속 받지 않게해서 조금 더 경량화하는 방향을 생각했습니다~! |
||
| data object Empty : UiState<Nothing> | ||
|
|
||
| data object Loading : UiState<Nothing>() | ||
| data object Loading : UiState<Nothing> | ||
|
|
||
| data class Success<T>( | ||
| val data: T, | ||
| ) : UiState<T>() | ||
| ) : UiState<T> | ||
|
|
||
| data class Failure( | ||
| val message: String, | ||
| ) : UiState<Nothing>() | ||
| ) : UiState<Nothing> | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 이거 패키지 옮겼군요
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extension과 util의 관계를 명확히 해야할 것 같아서용 ㅠㅠ ㅎㅎ;