Add SWXSOC Science Filename Parsing Test for Instrument Package Compliance#6
Merged
dbarrous merged 7 commits intoPADRESat:mainfrom Apr 28, 2025
Merged
Conversation
Alrobbertz
reviewed
Mar 3, 2025
savsky95
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
padre_sharpinstrument package to add back thecreate_science_filenamefunctions and oldutiltest suite so they can be managed by the instrument package team.It also adds the
test_validate_swxsoc_science_filenametest to ensure that instrument teams can define their owncreate_science_filenameimplementations while maintaining compliance with the SWXSOC naming convention.The test will be added to all other instrument packages after this PR, test for reference:
Also included:
Fixes to the SHARP faux processing so that it can handle the new file type and do a fake processing (just renaming the file) up to quicklook (ql). But it does do the file validation each time.