Possibility of installation via pip added #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 21, 2019 23:11
- modified sigma2splunkalert using relative path
|
Hi Florian, thank you very much for your contribution. I will review and merge it. Having one folder for the configuration is a good idea. |
|
Merge or close? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Patrick,
I added a simple setup.py to make it make it easier to use sigma2splunkalert.
In order to avoid conflicts with other packages I thought about moving all configuration files into a unique folder (like etc/sigma2splunkalert). But I didn't want to mess around with your folders. If it’s okay for you I can do this in a separate PR.