1st Version of collection transforming #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, sorry for the late response. I will review it as soon as possible. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Patrick
Sigma uses collections, and the output of the sigma converter places each of the searches in that collection on a new line. This breaks the search syntax in the savedsearches.conf file. I added the "or_collections" transforming command, which just adds these different searches of a collection with an " OR " to a one liner.
e.g.:
rules/windows/sysmon/sysmon_cmstp_execution.yml
rules/windows/sysmon/sysmon_logon_scripts_userinitmprlogonscript.yml
and so on...
Hope that unsolves syntax errors as well for others...
Andi