[18.0][MIG] pos_access_right: Migration to 18.0 by P-H-Phuc · Pull Request #4 · P-H-Phuc/pos

P-H-Phuc · 2025-07-11T10:31:38Z

This module extends Odoo Point Of Sale features, restricting possibility to cashier to make some actions in the Point of Sale. This module will add the following groups to Odoo:

PoS - Negative Quantity: The cashier can sell negative quantity in
Point Of Sale (ie, can return products);
PoS - Discount: The cashier can set Discount in Point Of Sale;
PoS - Change Unit Price: The cashier can change the unit price of
a product in Point Of Sale;
PoS - Many Orders: The cashier can many orders at the same time;
PoS - Delete Order: The cashier can not delete a full order;

anothingguy · 2025-07-14T08:52:49Z

1, can you squash Translation commits in history
2, let activate github CI tests on your forked report
3. You're changing behavior from old version to new version like:

compute readonly access group -> default editable group
disable button -> raising warning instead of disable.
I'm not sure what's the reasons for theses changes.

P-H-Phuc · 2025-07-16T04:16:10Z

pos_access_right/static/src/js/product_screen.esm.js

+    getNumpadButtons() {
+        const buttons = super.getNumpadButtons();
+        buttons.forEach((button) => {
+            if (button.value === 'discount') {
+                button.disabled = !this.hasManualDiscount;
+            } else if (button.value === 'price') {
+                button.disabled = !this.hasPriceControlRights;
+            } else if (button.value === '-') {
+                button.disabled = !this.hasMinusControlRights;
+            }
+        });
+        return buttons;


In this, I disabled numpad buttons instead of doing it in the XML file. Reference PR#132245

P-H-Phuc · 2025-07-16T04:23:06Z

'compute readonly access group -> default editable group'
I think an editable group is more flexible, but I kept it the same as before.

[REF] improve description; [ADD] fr translation; [ADD] new blockage; [ADD] fr translation; [IMP] description; [FIX] [FIX] display; [FIX] remove useless feature;[FIX] bug on multi order check [REF] rename fields [FIX] add missing author [REF] improve fr translation OCA Transbot updated translations from Transifex [UPD] Update pos_access_right.pot

[DOC] update README [FIX] fix variable name [REF] the pos.config model load all fields [DOC] update website link [LINT] fix lint errors [LINT] fix lint errors [UPD] README.rst [UPD] Update pos_access_right.pot

Updated by Update PO files to match POT (msgmerge) hook in Weblate. Added translation using Weblate (Russian)

Currently translated at 50.0% (10 of 20 strings) Translation: pos-12.0/pos-12.0-pos_access_right Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_access_right/ru/

[UPD] Update pos_access_right.pot [FIX] eslint [UPD] Update pos_access_right.pot

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_access_right Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_access_right/ [UPD] README.rst

[IMP] : black, isort, prettier

[UPD] Update pos_access_right.pot [UPD] README.rst pos_access_right 14.0.1.0.1 Translated using Weblate (French) Currently translated at 100.0% (23 of 23 strings) Translation: pos-14.0/pos-14.0-pos_access_right Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_access_right/fr/ Translated using Weblate (Catalan) Currently translated at 100.0% (23 of 23 strings) Translation: pos-14.0/pos-14.0-pos_access_right Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_access_right/ca/ [FIX] pos_access_right : remove bad css that impact all PoS

Translated using Weblate (Italian) Currently translated at 100.0% (25 of 25 strings) Translation: pos-14.0/pos-14.0-pos_access_right Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_access_right/it/

[UPD] Update pos_access_right.pot [BOT] post-merge updates

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-16.0/pos-16.0-pos_access_right Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_access_right/ Translated using Weblate (Spanish) Currently translated at 100.0% (17 of 17 strings) Translation: pos-16.0/pos-16.0-pos_access_right Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_access_right/es/ Translated using Weblate (Italian) Currently translated at 100.0% (17 of 17 strings) Translation: pos-16.0/pos-16.0-pos_access_right Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_access_right/it/ [FIX] eslint error 'no-shadow' in all modules [BOT] post-merge updates [FIX]pos_access_right: change deleteOrder to _onDeleteOrder [BOT] post-merge updates

pos_access_right/models/pos_config.py

+            config.group_delete_order_id = self.env.ref(
+                "pos_access_right.group_delete_order"
+            ).id
+            config.group_payment_id = self.env.ref("pos_access_right.group_payment").id


P-H-Phuc · 2026-01-28T07:55:35Z

pos_access_right/models/res_users.py

+        res = super()._load_pos_data(data)
+        config = data["pos.config"]["data"][0]
+
+        user = self.search([("id", "=", self.env.uid)], limit=1)


In Odoo Native, user is get by domain self._load_pos_data_domain(), I updated to use this method

pos_access_right/static/src/xml/action_pad.xml

+        t-name="ActionpadWidget"
+        t-inherit="point_of_sale.ActionpadWidget"
+        t-inherit-mode="extension"
+        owl="1"


nguyenminhchien · 2026-01-28T03:50:38Z

pos_access_right/static/src/js/product_screen.esm.js

+            } else if (button.value === "price") {
+                button.disabled = !this.hasPriceControlRights;
+            } else if (button.value === "-") {
+                button.disabled = !this.hasMinusControlRights;


You disabled the numpad, i could still set negative qty by pressing the minus key from my keyboard. Please check if version 12.0 faced the same problem or not. if yes, you could keep as it's.

In v12.0, it also dont use the minus key when pressed, I updated to disable this key. But what about the return/refund case?

I don't know that we have short keys for return and refund! what key are they?

I mean, in refund progress but user not allow minus control, so they cannot input quantity to refund

No problem, when inputting negative qty, the cashier want to refund.
So, it's the same matter.
keep your adjustment as now.

nguyenminhchien · 2026-01-28T04:06:25Z

pos_access_right/static/src/js/pos_store.esm.js

+    },
+    async pay() {
+        if (!this.user.raw.hasGroupPayment) {
+            this.dialog.add(AlertDialog, {


I cannot test this popup. when i has no payment right, the pay button is disabled. So, i cannot make the payment.

For trick cases, you can open Inspect (F12) and go to button element, remove disable atrribute

no, it's not what i mean. if there's no way i can test it, you could clean it.

nguyenminhchien · 2026-01-28T04:07:40Z

pos_access_right/static/src/js/ticket_screen.esm.js

+    },
+    async onDoRefund() {
+        if (!this.hasPaymentControlRights) {
+            this.dialog.add(AlertDialog, {


I cannot test this popup. when i has no payment right, the refund button is disabled. So, i cannot refund the order.

For trick cases, you can open Inspect (F12) and go to button element, remove disable atrribute

nguyenminhchien · 2026-01-28T04:10:39Z

pos_access_right/static/src/js/pos_store.esm.js

+patch(PosStore.prototype, {
+    async onDeleteOrder(order) {
+        if (!this.user.raw.hasGroupDeleteOrder) {
+            this.dialog.add(AlertDialog, {


I cannot test this popup. when i has no Delete right, the button is invisibled. So, i cannot delete the order.

For trick cases, you can open Inspect (F12) and go to button element, remove disable atrribute

nguyenminhchien · 2026-01-28T04:13:04Z

pos_access_right/models/res_users.py

+            hasGroupDiscount=config["group_discount_id"] in user_groups,
+            hasGroupNegativeQty=config["group_negative_qty_id"] in user_groups,
+            hasGroupPriceControl=config["group_change_unit_price_id"] in user_groups,
+            hasGroupMultiOrder=config["group_multi_order_id"] in user_groups,


No usage of the hasGroupMultiOrder

Removed this group. Cashier can open multi order screen

Keep it please. Disable this button instead

Hide button add new order

nguyenminhchien

Clean the useless code checks.
Disable the "Plus" button if has no Multi Order group.

nguyenminhchien · 2026-01-28T08:57:31Z

pos_access_right/static/src/js/product_screen.esm.js

+        ) {
+            this.dialog.add(AlertDialog, {
+                title: _t("Not Allowed"),
+                body: _t("You do not have permission to set negative quantity."),


Add French translation for them please

P-H-Phuc force-pushed the 18.0-mig-pos_access_right branch from 19b349b to 1a24d6e Compare July 14, 2025 03:28

P-H-Phuc closed this Jul 16, 2025

P-H-Phuc reopened this Jul 16, 2025

P-H-Phuc commented Jul 16, 2025

View reviewed changes

P-H-Phuc force-pushed the 18.0-mig-pos_access_right branch from 1a24d6e to 27c1e7a Compare July 16, 2025 04:20

legalsylvain and others added 15 commits July 16, 2025 11:25

[MIG] pos_access_right: Migration to 12.0

0728d63

[DOC] update README [FIX] fix variable name [REF] the pos.config model load all fields [DOC] update website link [LINT] fix lint errors [LINT] fix lint errors [UPD] README.rst [UPD] Update pos_access_right.pot

Update translation files

690e579

Updated by Update PO files to match POT (msgmerge) hook in Weblate. Added translation using Weblate (Russian)

Translated using Weblate (Russian)

e53d157

Currently translated at 50.0% (10 of 20 strings) Translation: pos-12.0/pos-12.0-pos_access_right Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_access_right/ru/

[ADD] block payment button

b575d67

[UPD] Update pos_access_right.pot [FIX] eslint [UPD] Update pos_access_right.pot

pos_access_right 12.0.1.0.1

367112a

Update translation files

97cb06f

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_access_right Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_access_right/ [UPD] README.rst

[MIG] pos_access_right : Migaration to 13.0

3f21756

[IMP] : black, isort, prettier

pos_access_right 14.0.1.0.2

79211ba

Added translation using Weblate (Italian)

4042708

Translated using Weblate (Italian) Currently translated at 100.0% (25 of 25 strings) Translation: pos-14.0/pos-14.0-pos_access_right Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_access_right/it/

[IMP] pos_access_right: pre-commit stuff

0ab4f3f

[MIG] pos_access_right: Migration to 16.0

ffd149d

[UPD] Update pos_access_right.pot [BOT] post-merge updates

[IMP] pos_access_right: pre-commit auto fixes

2286a9d

P-H-Phuc force-pushed the 18.0-mig-pos_access_right branch 3 times, most recently from 6c00045 to d63fc8f Compare July 16, 2025 04:38

P-H-Phuc marked this pull request as draft July 16, 2025 10:55

P-H-Phuc marked this pull request as ready for review January 27, 2026 08:55

nguyenminhchien suggested changes Jan 28, 2026

View reviewed changes

P-H-Phuc force-pushed the 18.0-mig-pos_access_right branch from d63fc8f to b738347 Compare January 28, 2026 07:52

P-H-Phuc requested a review from nguyenminhchien January 28, 2026 08:02

nguyenminhchien suggested changes Jan 28, 2026

View reviewed changes

P-H-Phuc force-pushed the 18.0-mig-pos_access_right branch 3 times, most recently from de1c4da to b04cb0c Compare January 28, 2026 10:49

P-H-Phuc requested a review from nguyenminhchien January 28, 2026 11:01

P-H-Phuc force-pushed the 18.0-mig-pos_access_right branch 2 times, most recently from 4fe709d to e37948c Compare January 29, 2026 03:59

nguyenminhchien approved these changes Jan 29, 2026

View reviewed changes

[MIG] pos_access_right: Migration to 18.0

ddc6f9b

P-H-Phuc force-pushed the 18.0-mig-pos_access_right branch from e37948c to ddc6f9b Compare January 29, 2026 04:13

Conversation

P-H-Phuc commented Jul 11, 2025

Uh oh!

anothingguy commented Jul 14, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

P-H-Phuc commented Jul 16, 2025

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

P-H-Phuc Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nguyenminhchien left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

P-H-Phuc Jan 28, 2026 •

edited

Loading