[18.0][MIG] base_edifact: Migration to 18.0 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[BOT] post-merge updates
[BOT] post-merge updates
[BOT] post-merge updates
[BOT] post-merge updates
Currently translated at 100.0% (1 of 1 strings) Translation: edi-16.0/edi-16.0-base_edifact Translate-URL: https://translation.odoo-community.org/projects/edi-16-0/edi-16-0-base_edifact/fr/
Currently translated at 100.0% (1 of 1 strings) Translation: edi-16.0/edi-16.0-base_edifact Translate-URL: https://translation.odoo-community.org/projects/edi-16-0/edi-16-0-base_edifact/it/
[BOT] post-merge updates
… in map2odoo_product - It will check the corresponding products later https://github.com/OCA/edi/blob/23be3483e846ce16d443a8148c4c8709cd7691ab/sale_order_import/wizard/sale_order_import.py#L268 - And will help to know which code/barcode we can not find the corresponding products in https://github.com/OCA/edi/blob/23be3483e846ce16d443a8148c4c8709cd7691ab/base_business_document_import/models/business_document_import.py#L677 [BOT] post-merge updates
…nt into account [BOT] post-merge updates
thienvh332
approved these changes
Jul 8, 2025
base_edifact/__manifest__.py
Outdated
| "website": "https://github.com/OCA/edi", | ||
| "author": "ALBA Software, PlanetaTIC, Odoo Community Association (OCA)", | ||
| "maintainers": ["rmorant"], | ||
| "maintainers": ["rmorant", "Phan Hong Phuc"], |
base_edifact/readme/CONTRIBUTORS.md
Outdated
| - Marc Poch \<[email protected]\> | ||
| - Duong (Tran Quoc) \<[email protected]\> | ||
| - Tris Doan \<[email protected]\> | ||
| - Phan Hong Phuc \<[email protected]\> |
There was a problem hiding this comment.
You should use the Trobz email here 😉
base_edifact/models/edifact.py
Outdated
Comment on lines
161
to
164
| if d.get("name"): | ||
| d["name"] = "{}{}".format(f"{d['name']}. ", seg[3]) | ||
| else: | ||
| d["name"] = seg[3] |
There was a problem hiding this comment.
Suggested change
| if d.get("name"): | |
| d["name"] = "{}{}".format(f"{d['name']}. ", seg[3]) | |
| else: | |
| d["name"] = seg[3] | |
| d["name"] = f"{d['name']}. {seg[3]}" if d.get("name") else seg[3] |
|
One more, drop the |
P-H-Phuc
force-pushed
the
18.0-mig-base-edifact
branch
2 times, most recently
from
d07590b to
5fe30d3
Compare
P-H-Phuc
force-pushed
the
18.0-mig-base-edifact
branch
from
5fe30d3 to
0dd1579
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration base_editfact from version 16.0 to version 18.0